Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we actually set a cache duration #304

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Ensure we actually set a cache duration #304

merged 1 commit into from
Oct 4, 2023

Conversation

dylanratcliffe
Copy link
Member

Since the CacheDuration was empty, it defaulted to zero, making the cache not work. This means that sources can still set their own, but we also have a sane default

@dylanratcliffe
Copy link
Member Author

This should hopefully fix overmindtech/discovery#183

@dylanratcliffe dylanratcliffe merged commit b45b256 into main Oct 4, 2023
4 checks passed
@dylanratcliffe dylanratcliffe deleted the fix-cache-duration branch October 4, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS-ovm DavidS-ovm Awaiting requested review from DavidS-ovm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dylanratcliffe