Merge pull request #669 from overmindtech/remove-deadcode

Removed `deadcode` as per overmindtech/golangci-lint_config#4
overmindtech · Nov 12, 2024 · 8b4c4e4 · 8b4c4e4
2 parents ee2fb79 + 88de757
commit 8b4c4e4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/.github/workflows/test-build.yml b/.github/workflows/test-build.yml
@@ -50,12 +50,6 @@ jobs:
       - name: Vet
         run: go vet ./...
 
-      - name: find deadcode
-        run: |
-          go install golang.org/x/tools/cmd/deadcode@latest
-          deadcode . > deadcode.txt
-          diff .deadcode-ignore deadcode.txt
-
       # get .golangci.yml from github.com/overmindtech/golangci-lint_config
       - name: Get .golangci.yml from github.com/overmindtech/golangci-lint_configs
         run: |

diff --git a/adapters/ec2-instance.go b/adapters/ec2-instance.go
@@ -82,6 +82,8 @@ func instanceOutputMapper(_ context.Context, _ *ec2.Client, scope string, _ *ec2
 					item.Health = sdp.Health_HEALTH_PENDING.Enum()
 				case codeStopping:
 					item.Health = sdp.Health_HEALTH_PENDING.Enum()
+				case codeTerminated, codeStopped:
+					// No health for things that aren't running
 				}
 			}