Skip to content

Commit

Permalink
Merge pull request #638 from overmindtech/allow_all_configs_to_run
Browse files Browse the repository at this point in the history
(fix) allow all configs to run in InitializeAwsSourceEngine
  • Loading branch information
tphoney authored Oct 2, 2024
2 parents 0fe42b7 + 76fcb2f commit 636762b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion proc/proc.go
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ func InitializeAwsSourceEngine(ctx context.Context, name string, version string,
return nil, err
}

p := pool.New().WithContext(ctx).WithCancelOnError()
p := pool.New().WithContext(ctx)

for _, cfg := range configs {
p.Go(func(ctx context.Context) error {
Expand Down
4 changes: 2 additions & 2 deletions sources/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"github.com/aws/aws-sdk-go-v2/aws/arn"
"github.com/aws/aws-sdk-go-v2/config"
"github.com/aws/aws-sdk-go-v2/service/sts"
awshttp "github.com/aws/smithy-go/transport/http"
awsHttp "github.com/aws/smithy-go/transport/http"
"github.com/overmindtech/discovery"
"github.com/overmindtech/sdp-go"
"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
Expand Down Expand Up @@ -114,7 +114,7 @@ func ParseARN(arnString string) (*ARN, error) {

// WrapAWSError Wraps an AWS error in the appropriate SDP error
func WrapAWSError(err error) *sdp.QueryError {
var responseErr *awshttp.ResponseError
var responseErr *awsHttp.ResponseError

if errors.As(err, &responseErr) {
// If the input is bad, access is denied, or the thing wasn't found then
Expand Down

0 comments on commit 636762b

Please sign in to comment.