feanil/fix uwsgi xml issues #1156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
feanil
commented
Nov 12, 2024
feanil
commented
- fix: nightly version suffix
- chore: ensure plugins are installed from nightly branches in nightly
- fix: upgrade MySQL from 5.7 to 8.1 first and then to 8.4
- feat: create volume for private LMS/CMS media assets (feat: create volume for private LMS/CMS media assets #1124)
- **feat: migrate from .local.edly.io to .local.openedx.io
- feat: update Open edX image to use ubuntu 22.04 as base OS (feat: update ubuntu #1117)
- fix: run MySQL 8.1 as a separate container during upgrade from Olive to Redwood (fix: run MySQL 8.1 as a separate container during upgrade from Olive to Redwood #1140)
- feat: add do command to change MySQL charset to utf8mb4 (feat: add do command to change MySQL charset to utf8mb4 #1079)
- fix: Don't build uwsgi with xml support.
This is required when upgrading from Tutor v15 to v18 directly MySQL does not allow direct upgrades from v5.7 to v8.4
Content Libraries will store asset files like images, transcripts, and PDFs using Learning Core–which in turn uses django-storages and expects some backing file store. These files should NOT be directly accessible via the browser, both because of access policies and the fact that the filenames will not be meaningful by themselves and must be translated by app logic. For details see: * https://github.com/openedx/openedx-learning/blob/main/docs/decisions/0015-serving-static-assets.rst * https://github.com/openedx/openedx-learning/blob/main/openedx_learning/apps/authoring/contents/models.py * https://github.com/openedx/openedx-learning/blob/main/openedx_learning/apps/authoring/components/models.py The existing /data/openedx-media -> /openedx/media mount is publicly accessible by browser, and so is not appropriate for this purpose. This commit creates a parallel /data/openedx-media-private -> /openedx/media-private volume mapping instead. This commit also creates configuration needed for openedx-learning to point to this new directory. This commit does NOT currently add support for this in k8s, as that will require changes to the minio plugin.
This makes it more clear for everyone that Tutor is an Open edX distribution. Close overhangio#1120
…o#1117) * feat: update Open edX image to use ubuntu 22.04 as base OS
…to Redwood (overhangio#1140) * ix: run MySQL 8.1 as a separate container during upgrade from Olive to Redwood We do this because MySQL 8.1 does not have the --mysql-native-password option We have this option turned on for backward compatibility
When uwsgi runs with xml support, it throws the following error on startup with the latest version of edx-platform: ``` xmlsec.InternalError: (-1, 'lxml & xmlsec libxml2 library version mismatch') ``` See xmlsec/python-xmlsec#320 for more details on this. Essentially, the uWSGI wheel is built against a different version of libxml2 and it causes this version mismach error when trying to load xmlsec. The xml support in uWSGI is only needed for runing with xml configuration files, which tutor does not do. Following the guidance of the above issue, I updated the `openedx` Dockerfile to no longer compile with any xml support as a part of the build. The time to build uWSGI was only slightly more than building from cache so I'm not concerned about major slowdowns in the build time for un-cached builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.