Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nightly] feat: add support for the Learner Dashboard MFE #164

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

arbrandes
Copy link
Collaborator

Adds support for the Learner Dashboard MFE.

The MFE itself still has a few pending fixes to make it release-ready (see the list of PRs in this issue), but we might as well merge it to nightly as we fix it up.

@arbrandes arbrandes requested a review from regisb November 16, 2023 15:36
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the smell of fresh microfrontends in the morning!

@arbrandes arbrandes merged commit 3c433a4 into overhangio:nightly Nov 16, 2023
@arbrandes arbrandes deleted the add-learner-dashboard branch November 16, 2023 18:38
@regisb
Copy link
Contributor

regisb commented Dec 5, 2023

@arbrandes I just discovered that the learner dashboard port clashes with the ecommerce MFE. Both use 1996:
https://github.com/openedx/frontend-app-ecommerce
https://github.com/openedx/frontend-app-learner-dashboard

As a consequence, we can no longer run the ecommerce plugin in nightly. We should change the port of one of these two MFEs in Tutor. Adolfo: which solution do you suggest? How does the devstack bypass this issue?

@arbrandes
Copy link
Collaborator Author

@regisb, the devstack doesn't ship frontend-app-ecommerce out of the box. Only frontend-app-payment. And that uses port 1998.

In any case, I don't have a strong opinion on which one should be changed, architecturally speaking. I will say, though, that whichever one is changed, it's also worth submitting the change upstream (to the MFE repo, devstack, etc). Let me know if you think it's the Dashboard that should change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants