Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS[NOETIC] Add a pcap source reader nodelet #344

Merged
merged 9 commits into from
Aug 15, 2024
Merged

ROS[NOETIC] Add a pcap source reader nodelet #344

merged 9 commits into from
Aug 15, 2024

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Jul 9, 2024 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Implement a pcap reader nodelet
  • Pace scans by the packets timestamps
  • Conditionality enable and link the pcap library
  • Display progress

Validation

  • Enable PCAP_BUILD flag and build the driver then execute:
roslaunch ouster_ros replay_pcap.launch \
pcap_file:=... \
metadata:= ..

@Samahu Samahu added the enhancement New feature or request label Jul 9, 2024
@Samahu Samahu self-assigned this Jul 9, 2024
@Samahu Samahu marked this pull request as ready for review August 2, 2024 18:55
matthew-lidar
matthew-lidar requested changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@matthew-lidar matthew-lidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!

launch/replay_pcap.launch Outdated Show resolved Hide resolved
launch/replay_pcap.launch Show resolved Hide resolved
src/os_pcap_nodelet.cpp Outdated Show resolved Hide resolved
src/os_pcap_nodelet.cpp Show resolved Hide resolved
src/os_pcap_nodelet.cpp Show resolved Hide resolved
src/os_pcap_nodelet.cpp Show resolved Hide resolved
src/os_pcap_nodelet.cpp Outdated Show resolved Hide resolved
src/os_pcap_nodelet.cpp Show resolved Hide resolved
src/os_pcap_nodelet.cpp Outdated Show resolved Hide resolved
@Samahu Samahu mentioned this pull request Aug 7, 2024
Merged
@Samahu Samahu changed the title Add a pcap source reader nodelet ROS[NOETIC] Add a pcap source reader nodelet Aug 15, 2024
@Samahu Samahu mentioned this pull request Aug 15, 2024
Merged
twslankard
twslankard approved these changes Aug 15, 2024
View reviewed changes
src/os_pcap_nodelet.cpp Outdated Show resolved Hide resolved
src/os_pcap_nodelet.cpp Show resolved Hide resolved
@Samahu Samahu merged commit 993e471 into master Aug 15, 2024
1 check passed
@Samahu Samahu deleted the add-pcap-reader branch August 15, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-lidar matthew-lidar matthew-lidar approved these changes

@twslankard twslankard twslankard approved these changes

@celentes celentes Awaiting requested review from celentes

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

@akatumalla-ouster akatumalla-ouster Awaiting requested review from akatumalla-ouster

Assignees

@Samahu Samahu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reading a pcap file convert pcap to rosbag Reading .pcap files
3 participants
@Samahu @twslankard @matthew-lidar