-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new devices for avr-size
#318
base: main
Are you sure you want to change the base?
Conversation
thanks @chenzhuoyu for the PR. where is the patch from? |
Formula/avr-binutils.rb
Outdated
@@ -27,8 +27,8 @@ class AvrBinutils < Formula | |||
|
|||
# Support for -C in avr-size | |||
patch do | |||
url "https://raw.githubusercontent.com/archlinux/svntogit-community/c3efadcb76f4d8b1a3784015e7c472f59dbfa7de/avr-binutils/repos/community-x86_64/avr-size.patch" | |||
sha256 "7aed303887a8541feba008943d0331dc95dd90a309575f81b7a195650e4cba1e" | |||
url "https://raw.githubusercontent.com/chenzhuoyu/homebrew-avr/2676e4caa70022cf7b087f7c1bb676e368343190/Patch/avr-binutils-size.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this must point to the patch in this repository, not in yours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... but how do I put this patch file into this repo before... well putting this patch file into this repo? Should I split this into two PRs where the first one adds a patch file, and the second one applies the patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ladislas I reverted the changes in avr-binutils.rb
for this PR. After this PR got merged, I will open another PR to apply the patch.
|
@ladislas Any updates on this? |
it's in my long long todo list, but I'm a bit overwhelmed at the moment 😓 I also don't use avr/arduino that much now, so getting the pieces to test this is not an easy task. @osx-cross/team what's your take on this? @chenzhuoyu give me a few more days to dive into it. |
This PR adds support for these (comprehensive list) new AVR devices into
avr-size
:Now it reports the correct device and memory usage rather than "Unknown":