[ci] More test & build fixes

ossia · Sep 23, 2023 · 63f2eb4 · 63f2eb4
1 parent bc4592b
commit 63f2eb4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/cmake/OssiaDeps.cmake b/cmake/OssiaDeps.cmake
@@ -16,6 +16,7 @@ if(OSSIA_SUBMODULE_AUTOUPDATE)
       SmallFunction
       span
       spdlog
+      tuplet
       unordered_dense
       verdigris
       weakjack

diff --git a/src/ossia-pd/src/utils.cpp b/src/ossia-pd/src/utils.cpp
@@ -86,10 +86,10 @@ std::string string_from_path(const std::vector<std::string>& vs)
   auto rit = vs.rbegin();
   for(; rit != vs.rend(); ++rit)
   {
-    fmt::format_to(b, "/{}", *rit);
+    fmt::format_to(fmt::appender(b), "/{}", *rit);
   }
   if(vs.empty())
-    fmt::format_to(b, "/");
+    fmt::format_to(fmt::appender(b), "/");
 
   return {b.data(), b.size()};
 }

diff --git a/tests/Editor/DomainTest.cpp b/tests/Editor/DomainTest.cpp
@@ -663,12 +663,12 @@ TEST_CASE("test_get_min_max", "test_get_min_max")
   set_max(d, int{25});
   REQUIRE(get_max(d) == int{25});
 
-  // No value
+  // Converted
   set_min(d, float{7});
-  REQUIRE(get_min(d) == value{});
+  REQUIRE(get_min(d) == int{7});
 
-  set_max(d, float{42});
-  REQUIRE(get_max(d) == value{});
+  set_max(d, float{42.2f});
+  REQUIRE(get_max(d) == int{42});
 }
 
 { // Generic domain