Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indirection for changes in empy 3 vs 4 #261

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Add indirection for changes in empy 3 vs 4 #261

merged 3 commits into from
Dec 6, 2023

Conversation

tfoote
Copy link
Collaborator

@tfoote tfoote commented Dec 5, 2023

It adds a helper function to provide the indirection across the breaking change.

Fixes #259

Working towards #259
This is not backwards compatible at the moment. But works with empy==4.0
@tfoote
Copy link
Collaborator Author

tfoote commented Dec 6, 2023

Validated in #259 (comment)

@tfoote tfoote merged commit 4de56c1 into main Dec 6, 2023
8 checks passed
@tfoote tfoote deleted the empy4_fixes branch December 6, 2023 22:05
tfoote added a commit that referenced this pull request Dec 6, 2023
@tfoote tfoote mentioned this pull request Dec 6, 2023
tfoote added a commit that referenced this pull request Dec 10, 2023
@miguelprada
Copy link
Contributor

empy has been updated to 4.0.1 which apparently fixes the backward compatibility problem 4.0.0 introduced. Just found out while failing to reproduce issues a colleague was having with my extensions and empy.

Just FYI, in case you prefer to revert this and possibly exclude the "buggy" 4.0.0 version of empy in the requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use --nvidia flag with updated empy==4.0
2 participants