Force env extension to the end, before user

[galou]

Signed-off-by: Gaël Écorchard [email protected]

[tfoote]

Quick cleanup on the patch, but otherwise this looks good. Moving the logic into the core makes sense. It would be great to add a quick unit test for this logic too to make sure it doesn't break with any future refactoring.

[tfoote]

Same comments here about changing the version and the unrelated changes.

[galou]

Sorry, I don't get it, the other version change was for the minor number but here I changed the patch version. Do you mean that I should let the version to 0.2.3?

[galou]

I have to admit that I don't know how to write a unit test to test that the env extension is one before the last when it's supposed to be the sole extension tested.

[galou]

Sorry, I don't get it, the other version change was for the minor number but here I changed the patch version. Do you mean that I should let the version to 0.2.3?

[tfoote]

I should let the version to 0.2.3?

Correct. Your patch may be bundled in with other patches and then a release made. The version number will be bumped during the release process and is separate from your changes.

[galou]

Reverted the version number and unrelated changes. Should I squeeze commits?

[tfoote]

Thanks for the cleanup.

I have to admit that I don't know how to write a unit test to test that the env extension is one before the last when it's supposed to be the sole extension tested.

To write the test, you'll need to invoke it with a couple of extensions enabled and check the ordering.

extending this test

rocker/test/test_core.py

Line 123 in 280b5e1

self.assertEqual(active_extensions[0].get_name(), 'user')

Coverage should be decent with the following tests:

• push user to last
• push env to last except user
• push env to second to last with user

[agyoungs]

If #242 is merged, the method to get the 'env' extension loaded just before the 'user' extension will need to be modified