Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Ignition Garden 🔥🌱 #107

Merged
merged 16 commits into from
Dec 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ docker/join.sh mbari_lrauv
## To build

To run the code in this repository natively without Docker, make sure you have
[Ignition Fortress](https://ignitionrobotics.org/docs/fortress) and
[Ignition Garden](https://ignitionrobotics.org/docs/garden) and
[colcon](https://colcon.readthedocs.io/en/released/), on Ubuntu Focal or higher.

Install dependencies
Expand Down
5 changes: 3 additions & 2 deletions docker/debug_integration/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# Research Institute (MBARI) and the David and Lucile Packard Foundation
#

FROM mbari/lrauv-ignition-sim
FROM mbari/lrauv-ignition-sim:garden

USER root

Expand All @@ -41,11 +41,12 @@ RUN apt-get update \

# Add Ignition's latest packages, which may be more up-to-date than the ones from the MBARI image
RUN /bin/sh -c 'echo "deb http://packages.osrfoundation.org/gazebo/ubuntu-stable `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-stable.list' && \
/bin/sh -c 'echo "deb http://packages.osrfoundation.org/gazebo/ubuntu-nightly `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-nightly.list' && \
/bin/sh -c 'wget http://packages.osrfoundation.org/gazebo.key -O - | apt-key add -'

# Install the latest Ignition binaries
RUN apt-get -qq update && apt-get -q -y install \
ignition-fortress
ignition-garden

# Install PCL
RUN apt-get update \
Expand Down
5 changes: 3 additions & 2 deletions docker/empty_world/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,13 @@ RUN apt-get -qq update && apt-get -q -y install \
ENV IGN_WS /home/ign_ws
RUN mkdir -p ${IGN_WS}/src \
&& cd ${IGN_WS}/src \
&& wget https://raw.githubusercontent.com/ignition-tooling/gazebodistro/master/collection-fortress.yaml \
&& vcs import < collection-fortress.yaml
&& wget https://raw.githubusercontent.com/ignition-tooling/gazebodistro/master/collection-garden.yaml \
&& vcs import < collection-garden.yaml

# Install Ignition dependencies
# This parses Ignition source tree to find package dependencies
RUN /bin/sh -c 'echo "deb http://packages.osrfoundation.org/gazebo/ubuntu-stable `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-stable.list' \
&& /bin/sh -c 'echo "deb http://packages.osrfoundation.org/gazebo/ubuntu-nightly `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-nightly.list' \
&& /bin/sh -c 'wget http://packages.osrfoundation.org/gazebo.key -O - | apt-key add -' \
&& apt-get update \
&& apt-get install -y \
Expand Down
5 changes: 3 additions & 2 deletions docker/tests/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# Research Institute (MBARI) and the David and Lucile Packard Foundation
#

FROM mbari/lrauv-ignition-sim
FROM mbari/lrauv-ignition-sim:garden

USER root

Expand All @@ -41,11 +41,12 @@ RUN apt-get update \

# Add Ignition's latest packages, which may be more up-to-date than the ones from the MBARI image
RUN /bin/sh -c 'echo "deb http://packages.osrfoundation.org/gazebo/ubuntu-stable `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-stable.list' && \
/bin/sh -c 'echo "deb http://packages.osrfoundation.org/gazebo/ubuntu-nightly `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-nightly.list' && \
/bin/sh -c 'wget http://packages.osrfoundation.org/gazebo.key -O - | apt-key add -'

# Install the latest Ignition binaries
RUN apt-get -qq update && apt-get -q -y install \
ignition-fortress
ignition-garden

# Install PCL
RUN apt-get update \
Expand Down
2 changes: 1 addition & 1 deletion lrauv_description/models/tethys_equipped/model.sdf
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
</plugin>
<plugin
filename="ignition-gazebo-buoyancy-engine-system"
name="ignition::gazebo::v6::systems::BuoyancyEnginePlugin">
name="ignition::gazebo::systems::BuoyancyEngine">
<link_name>buoyancy_engine</link_name>
<namespace>tethys</namespace>
<fluid_density>1000</fluid_density>
Expand Down
20 changes: 10 additions & 10 deletions lrauv_ignition_plugins/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,20 @@ endif()
# Find dependencies
find_package(ignition-cmake2 REQUIRED)

find_package(ignition-gazebo6 REQUIRED COMPONENTS gui)
set(IGN_GAZEBO_VER ${ignition-gazebo6_VERSION_MAJOR})
find_package(ignition-gazebo7 REQUIRED COMPONENTS gui)
set(IGN_GAZEBO_VER ${ignition-gazebo7_VERSION_MAJOR})

find_package(ignition-gui6 REQUIRED)
set(IGN_GUI_VER ${ignition-gui6_VERSION_MAJOR})
find_package(ignition-gui7 REQUIRED)
set(IGN_GUI_VER ${ignition-gui7_VERSION_MAJOR})

find_package(ignition-rendering6 REQUIRED)
set(IGN_RENDERING_VER ${ignition-rendering6_VERSION_MAJOR})
find_package(ignition-rendering7 REQUIRED)
set(IGN_RENDERING_VER ${ignition-rendering7_VERSION_MAJOR})

find_package(ignition-sensors6 REQUIRED)
set(IGN_SENSORS_VER ${ignition-sensors6_VERSION_MAJOR})
find_package(ignition-sensors7 REQUIRED)
set(IGN_SENSORS_VER ${ignition-sensors7_VERSION_MAJOR})

find_package(ignition-msgs8 REQUIRED)
set(IGN_MSGS_VER ${ignition-msgs8_VERSION_MAJOR})
find_package(ignition-msgs9 REQUIRED)
set(IGN_MSGS_VER ${ignition-msgs9_VERSION_MAJOR})

find_package(ignition-plugin1 REQUIRED COMPONENTS register)
set(IGN_PLUGIN_VER ${ignition-plugin1_VERSION_MAJOR})
Expand Down
2 changes: 1 addition & 1 deletion lrauv_ignition_plugins/src/WorldCommPlugin.cc
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ std::string WorldCommPlugin::TethysSdfString(const std::string &_id)
<state_topic>)" + _id + R"(/state_topic</state_topic>
</plugin>

<plugin element_id="ignition::gazebo::v6::systems::BuoyancyEnginePlugin" action="modify">
<plugin element_id="ignition::gazebo::systems::BuoyancyEngine" action="modify">
<namespace>)" + _id + R"(</namespace>
</plugin>

Expand Down
2 changes: 1 addition & 1 deletion lrauv_ignition_plugins/test/test_mission_yoyo_circle.cc
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ TEST_F(LrauvTestFixture, YoYoCircle)
if (i > 2000)
{
// Check that the vehicle actually is moving.
EXPECT_LT(0.0, linVel);
EXPECT_LT(0.0, linVel) << i;
}

EXPECT_NEAR(1.0, linVel, 1.0) << i;
Expand Down
4 changes: 2 additions & 2 deletions lrauv_ignition_plugins/worlds/multi_lrauv.sdf
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
<command_topic>triton/command_topic</command_topic>
<state_topic>triton/state_topic</state_topic>
</plugin>
<plugin element_id="ignition::gazebo::v6::systems::BuoyancyEnginePlugin" action="modify">
<plugin element_id="ignition::gazebo::systems::BuoyancyEngine" action="modify">
<namespace>triton</namespace>
</plugin>
<plugin element_id="ignition::gazebo::systems::DetachableJoint" action="modify">
Expand Down Expand Up @@ -174,7 +174,7 @@
<command_topic>daphne/command_topic</command_topic>
<state_topic>daphne/state_topic</state_topic>
</plugin>
<plugin element_id="ignition::gazebo::v6::systems::BuoyancyEnginePlugin" action="modify">
<plugin element_id="ignition::gazebo::systems::BuoyancyEngine" action="modify">
<namespace>daphne</namespace>
</plugin>
<plugin element_id="ignition::gazebo::systems::DetachableJoint" action="modify">
Expand Down
8 changes: 4 additions & 4 deletions lrauv_ignition_plugins/worlds/star_world.sdf
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<command_topic>tethys2/command_topic</command_topic>
<state_topic>tethys2/state_topic</state_topic>
</plugin>
<plugin element_id="ignition::gazebo::v6::systems::BuoyancyEnginePlugin" action="modify">
<plugin element_id="ignition::gazebo::systems::BuoyancyEngine" action="modify">
<namespace>tethys2</namespace>
</plugin>
<plugin element_id="ignition::gazebo::systems::DetachableJoint" action="modify">
Expand Down Expand Up @@ -137,7 +137,7 @@
<command_topic>tethys3/command_topic</command_topic>
<state_topic>tethys3/state_topic</state_topic>
</plugin>
<plugin element_id="ignition::gazebo::v6::systems::BuoyancyEnginePlugin" action="modify">
<plugin element_id="ignition::gazebo::systems::BuoyancyEngine" action="modify">
<namespace>tethys3</namespace>
</plugin>
<plugin element_id="ignition::gazebo::systems::DetachableJoint" action="modify">
Expand Down Expand Up @@ -178,7 +178,7 @@
<command_topic>tethys4/command_topic</command_topic>
<state_topic>tethys4/state_topic</state_topic>
</plugin>
<plugin element_id="ignition::gazebo::v6::systems::BuoyancyEnginePlugin" action="modify">
<plugin element_id="ignition::gazebo::systems::BuoyancyEngine" action="modify">
<namespace>tethys4</namespace>
</plugin>
<plugin element_id="ignition::gazebo::systems::DetachableJoint" action="modify">
Expand All @@ -196,6 +196,6 @@
</include>



</world>
</sdf>