Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permission sidebar #54

Merged
merged 13 commits into from
Jul 24, 2024
Merged

Permission sidebar #54

merged 13 commits into from
Jul 24, 2024

Conversation

Zelzahn
Copy link
Collaborator

@Zelzahn Zelzahn commented Jul 23, 2024 •
edited
Loading

image

  • Support for the public "agent"
  • Refetch the data after changing permissions and it errors
  • Selecting a different resource doesn't invalidate the state of the LoSwitch.vue's
  • The notification after modifying the permission should probably be something prettier than { "ok": true, "value": "The change is successfully performed!" }

@Zelzahn Zelzahn marked this pull request as ready for review July 24, 2024 08:26
Vicba
Vicba approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@Vicba Vicba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

BT-Creator
BT-Creator approved these changes Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@BT-Creator BT-Creator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zelzahn Zelzahn merged commit c8a6add into root Jul 24, 2024
4 checks passed
@Zelzahn Zelzahn deleted the 34-permission-sidebar branch July 24, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BT-Creator BT-Creator BT-Creator approved these changes

@Vicba Vicba Vicba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zelzahn @Vicba @BT-Creator