Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfocus of RGB / HEX fields causes color value to change #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Reggino
Copy link

@Reggino Reggino commented Jan 18, 2012

Hi Olav!

Great work on the ColorPicker component. It works great!

I found a small bug however. When a user fills out some HEX value (e.g. AAAAAA) and the focuses the next field, the color value gets re-calculated and changes. This way, a user can not fill out the exact RBG value.

This commit fixes this issue by providing a rgb OR hsv value as the new color value. The field is updated accordingly.

Tim de Koning added 3 commits January 18, 2012 18:25
… values were return as 0.31, 0.12, 0.11 and sometimes they where returned as 131, 32, 11. Besides: the values seemed a bit off....

Implemented new RGB2HSV and HSV2RGB logic and standardized the use...
@osnoek
Copy link
Owner

osnoek commented Jan 31, 2012

Hi Kingsquare,

Thanks for the feedback. Sorry for the late response. I will review your code and merge it with the modifications I have made myself and will then merge those into the trunk.

As for the "me" versus "this" it's a question of personal preference :)

Will let you know when your changes have been merged.

Cheers,

Olav

@Reggino
Copy link
Author

Reggino commented Jan 31, 2012

Hi Olav,

Thanx! And again: great work on the plug-in, i love it!

But please do re-consider removing 'me' references, because i think it has more implications than personal preferences: it means extra & unneeded lines of code, introducing extra unneeded variables and why not name it 'this' since 'this' is how JavaScript describes the scope? Using native language constructs is i.m.h.o. better the using your own type of referencing to the same this....

Thanks again!

Tim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants