Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic exterior algebra and relative BGG #4360

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

HechtiDerLachs
Copy link
Collaborator

This is a rebase of #4097 .

@HechtiDerLachs HechtiDerLachs marked this pull request as draft November 27, 2024 15:28
Comment on lines +7 to +8
const AdmissibleModuleFPRingElem = NCRingElem
const AdmissibleModuleFPRing = NCRing
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking into how to not widen the signatures of AdmissibleRingElems for the ModuleFPs to all of NCRingElem, but failed for the following reasons. So far, we declare the AdmissibleRingElems as const. That means we have to include all types we would like to put into this union up front. In the case of ExtAlgElem and its parent, this is bad, because they use FreeMods in their internals! So the cat bites its tail here and I haven't yet figured out a good way to resolve this.

Either way, we need to resolve this before merging!

@HechtiDerLachs
Copy link
Collaborator Author

I guess, I should still add some more comments and documentation. But I would like to keep this PR in the loop, as it is a take on one project which has explicitly been mentioned in the SFB application and I presume that there is some interest in taking things forward here.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 86.81447% with 113 lines in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (3af3c91) to head (9351670).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...xperimental/ExteriorAlgebra/src/ExteriorAlgebra.jl 85.47% 87 Missing ⚠️
experimental/ExteriorAlgebra/src/BGG_complex.jl 88.23% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4360      +/-   ##
==========================================
+ Coverage   84.30%   84.38%   +0.07%     
==========================================
  Files         651      653       +2     
  Lines       86483    87339     +856     
==========================================
+ Hits        72913    73701     +788     
- Misses      13570    13638      +68     
Files with missing lines Coverage Δ
experimental/ExteriorAlgebra/src/Types.jl 100.00% <100.00%> (ø)
experimental/ExteriorAlgebra/test/runtests.jl 95.08% <100.00%> (+4.17%) ⬆️
src/Modules/ModuleTypes.jl 78.90% <ø> (ø)
src/Modules/ModulesGraded.jl 73.96% <ø> (+0.46%) ⬆️
src/Oscar.jl 69.51% <100.00%> (ø)
experimental/ExteriorAlgebra/src/BGG_complex.jl 88.23% <88.23%> (ø)
...xperimental/ExteriorAlgebra/src/ExteriorAlgebra.jl 85.05% <85.47%> (+8.38%) ⬆️

... and 9 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants