-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic exterior algebra and relative BGG #4360
base: master
Are you sure you want to change the base?
Generic exterior algebra and relative BGG #4360
Conversation
const AdmissibleModuleFPRingElem = NCRingElem | ||
const AdmissibleModuleFPRing = NCRing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking into how to not widen the signatures of AdmissibleRingElem
s for the ModuleFP
s to all of NCRingElem
, but failed for the following reasons. So far, we declare the AdmissibleRingElem
s as const
. That means we have to include all types we would like to put into this union up front. In the case of ExtAlgElem
and its parent, this is bad, because they use FreeMod
s in their internals! So the cat bites its tail here and I haven't yet figured out a good way to resolve this.
Either way, we need to resolve this before merging!
I guess, I should still add some more comments and documentation. But I would like to keep this PR in the loop, as it is a take on one project which has explicitly been mentioned in the SFB application and I presume that there is some interest in taking things forward here. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4360 +/- ##
==========================================
+ Coverage 84.30% 84.38% +0.07%
==========================================
Files 651 653 +2
Lines 86483 87339 +856
==========================================
+ Hits 72913 73701 +788
- Misses 13570 13638 +68
|
This is a rebase of #4097 .