Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash method for RayVector #4354

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add hash method for RayVector #4354

wants to merge 1 commit into from

Conversation

alexej-jordan
Copy link
Collaborator

No description provided.

@alexej-jordan
Copy link
Collaborator Author

With this notion we already have a good distinction what could be equal. The disadvantage is that calculating the sign could be too demanding for more complex coefficient fields? If so, we could utilize the efficient is_zero function: Base.hash(x::RayVector, h::UInt) = hash(iszero.(x), hash(coefficient_field(x), h))

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (4d753d8) to head (7e21a09).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4354   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files         649      649           
  Lines       86345    86346    +1     
=======================================
+ Hits        72799    72800    +1     
  Misses      13546    13546           
Files with missing lines Coverage Δ
src/PolyhedralGeometry/iterators.jl 92.09% <100.00%> (+0.04%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant