Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ToricVarieties] Tests for blowup do not depend on order of rays anymore #4353

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[ToricVarieties] Tests for blowup do not depend on order of rays anymore #4353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions test/AlgebraicGeometry/ToricVarieties/toric_blowups.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
BP2 = domain(blow_up(P2, 1; coordinate_name = "e"))

@testset "Basic properties of BP2" begin
@test is_normal(BP2) == true
@test is_affine(BP2) == false
@test is_projective(BP2) == true
@test is_projective_space(BP2) == false
@test is_smooth(BP2) == true
@test is_complete(BP2) == true
@test is_orbifold(BP2) == true
@test is_simplicial(BP2) == true
@test has_torusfactor(BP2) == false
@test is_normal(BP2)
@test !is_affine(BP2)
@test is_projective(BP2)
@test !is_projective_space(BP2)
@test is_smooth(BP2)
@test is_complete(BP2)
@test is_orbifold(BP2)
@test is_simplicial(BP2)
@test !has_torusfactor(BP2)
end

@testset "Basic attributes of BP2" begin
Expand Down Expand Up @@ -41,7 +41,7 @@
@testset "Basic tests for simple toric blowup" begin
@test torsion_free_rank(domain(grid_morphism(bl))) == 2
@test torsion_free_rank(codomain(grid_morphism(bl))) == 2
@test matrix(morphism_on_torusinvariant_weil_divisor_group(bl)) == matrix(ZZ, [1 0 0; 0 1 0; 0 0 1; 1 1 0])
@test rank(matrix(morphism_on_torusinvariant_weil_divisor_group(bl))) == 3
@test matrix(morphism_on_torusinvariant_cartier_divisor_group(bl)) == matrix(morphism_on_torusinvariant_weil_divisor_group(bl))
end

Expand Down Expand Up @@ -77,4 +77,5 @@
@test bl2 isa Oscar.ToricBlowupMorphism
@test center_unnormalized(bl2) == II
end

end
Loading