Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up generic characteristic method for localized rings. #4346

Merged

Conversation

HechtiDerLachs
Copy link
Collaborator

This is to address #4324.

@thofma : The second issue pointed out by you in #4324 is not yet resolved with this. Does the ball lay in my yard with that one, too? Or is it an issue of polynomial rings?

@lgoettgens lgoettgens changed the title Fix up generic method for of localized rings. Fix up generic characteristic method for of localized rings. Nov 25, 2024
@HechtiDerLachs HechtiDerLachs changed the title Fix up generic characteristic method for of localized rings. Fix up generic characteristic method for localized rings. Nov 25, 2024
@thofma
Copy link
Collaborator

thofma commented Nov 25, 2024

Thanks. The problems with polynomial rings over zero rings are being addressed elsewhere.

@HechtiDerLachs
Copy link
Collaborator Author

Alright. I hope the tests pass. I do not oversee at the moment to which extent we have been using the characteristic method. So maybe we already need to implement some more cases. But if not, then throwing an error for now should be fine.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.52%. Comparing base (3e670f7) to head (d2d8516).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Rings/localization_interface.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4346      +/-   ##
==========================================
- Coverage   84.52%   84.52%   -0.01%     
==========================================
  Files         645      645              
  Lines       85706    85710       +4     
==========================================
+ Hits        72440    72443       +3     
- Misses      13266    13267       +1     
Files with missing lines Coverage Δ
src/Rings/localization_interface.jl 60.84% <80.00%> (+0.30%) ⬆️
---- 🚨 Try these New Features:

@lgoettgens lgoettgens merged commit f849adc into oscar-system:master Nov 25, 2024
30 checks passed
@HechtiDerLachs HechtiDerLachs deleted the fix_characteristic_bug branch November 25, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants