Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] Added additional zero section functionality #4343

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

emikelsons
Copy link
Collaborator

@emikelsons
Copy link
Collaborator Author

cc @HereAround @apturner

Added zero_section_index and fixed some previous typos.
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.52%. Comparing base (3e670f7) to head (bf8cc4d).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4343   +/-   ##
=======================================
  Coverage   84.52%   84.52%           
=======================================
  Files         645      645           
  Lines       85706    85714    +8     
=======================================
+ Hits        72440    72447    +7     
- Misses      13266    13267    +1     
Files with missing lines Coverage Δ
...heoryTools/src/AbstractFTheoryModels/attributes.jl 99.60% <100.00%> (+<0.01%) ⬆️
.../FTheoryTools/src/AbstractFTheoryModels/methods.jl 78.33% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

@HereAround
Copy link
Member

Thank you for working on this @emikelsons . Looks good.

Since #4286 has been merged, we should use the zero_section_index in this functionality. Please look into this @emikelsons (in a separate PR). Thank you!

@HereAround HereAround merged commit ba8f438 into oscar-system:master Nov 26, 2024
30 checks passed
@emikelsons emikelsons deleted the ZeroSectionsMore branch November 26, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants