Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LieAlgebras: Add Demazure character #4339

Merged
merged 12 commits into from
Nov 27, 2024

Conversation

janikapeters
Copy link
Contributor

@janikapeters janikapeters commented Nov 21, 2024

Implemented by the request of @lgoettgens and @gfourier
I am still writing documentation and tests

@lgoettgens lgoettgens added topic: LieAlgebras experimental Only changes experimental parts of the code labels Nov 21, 2024
@lgoettgens
Copy link
Member

Just for future reference: @janikapeters is a student assistant at RWTH Aachen under the supervision of @gfourier and me working on project A24, in particular in extending the BasisLieHighestWeight experimental project to work for Demazure modules.

experimental/LieAlgebras/src/RootSystem.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/RootSystem.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/RootSystem.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/RootSystem.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/RootSystem.jl Outdated Show resolved Hide resolved
experimental/LieAlgebras/src/RootSystem.jl Show resolved Hide resolved
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 97.64706% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.32%. Comparing base (4d753d8) to head (a326c1b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
experimental/LieAlgebras/src/RootSystem.jl 96.72% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4339      +/-   ##
==========================================
+ Coverage   84.31%   84.32%   +0.01%     
==========================================
  Files         649      649              
  Lines       86345    86430      +85     
==========================================
+ Hits        72799    72882      +83     
- Misses      13546    13548       +2     
Files with missing lines Coverage Δ
experimental/LieAlgebras/src/LieAlgebraModule.jl 88.83% <100.00%> (+0.32%) ⬆️
experimental/LieAlgebras/src/LieAlgebras.jl 100.00% <ø> (ø)
...rimental/LieAlgebras/test/LieAlgebraModule-test.jl 100.00% <100.00%> (ø)
experimental/LieAlgebras/src/RootSystem.jl 93.73% <96.72%> (+0.25%) ⬆️

@lgoettgens
Copy link
Member

just as a small heads-up: #4344 is very probably creating some conflicts with this PR here. I can try to help you with that when you drop by my office later today

@janikapeters janikapeters marked this pull request as ready for review November 26, 2024 17:51
Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lgoettgens lgoettgens enabled auto-merge (squash) November 26, 2024 17:55
@lgoettgens lgoettgens merged commit 9da6d04 into oscar-system:master Nov 27, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code topic: LieAlgebras
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants