Improve test coverage for CartanMatrix.jl #4295
Open
+140
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
topic: LieAlgebras
experimental
lgoettgens
reviewed
Nov 9, 2024
| if i != 2 | ||
| @test_throws ArgumentError cartan_matrix(:G, i) | ||
| end | ||
| end |
There was a problem hiding this comment.
can you transform this block of tests into tests for is_cartan_type and then test the cartan matrix constructor via
for i in -1:10, fam in (:A, :B, :C, :D, :E, :F, :G)
if is_cartan_type(fam, i)
cartan_matrix(fam, i)
else
@test_throws ArgumentError cartan_matrix(fam, i)
end
end?
| @test cartan_symmetrizer(cartan_matrix((:C, 4), (:G, 2))) == [[1, 1, 1, 2]; [1, 3]] | ||
|
|
||
| @test cartan_symmetrizer(ZZ[2 -2 0; -1 2 -1; 0 -1 2]) == [1, 2, 2] | ||
| @test cartan_symmetrizer(ZZ[2 0 -1 0; 0 2 0 -2; -2 0 2 0; 0 -1 0 2]) == [2, 1, 1, 2] |
There was a problem hiding this comment.
these are still indirectly tested via the bilinear form test below, right?
| end | ||
|
|
||
| bil = cartan_bilinear_form(cm) | ||
| @test is_symmetric(bil) == true |
There was a problem hiding this comment.
Suggested change
| @test is_symmetric(bil) == true | |
| @test is_symmetric(bil) |
|
Regarding the failure in the 1.10 CI, I think you told me that you know where this comes from and how to work around, right? cartan_bilinear_form: Test Failed at /home/runner/work/Oscar.jl/Oscar.jl/experimental/LieAlgebras/test/CartanMatrix-test.jl:130
Expression: is_symmetric(bil) == true
Evaluated: false == true |
felix-roehrich
force-pushed
the
fr/cartan-test-cov
branch
from
87af244
to
4d78ac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase test coverage of CartanMatrix.jl to prepare for #4263.