-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTheoryTools] Implement G4-fluxes #3965
Conversation
718df0d
to
4e9180d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3965 +/- ##
==========================================
- Coverage 84.33% 84.32% -0.02%
==========================================
Files 593 596 +3
Lines 81750 81853 +103
==========================================
+ Hits 68945 69022 +77
- Misses 12805 12831 +26
|
cff46e1
to
aed0131
Compare
139470d
to
c69d956
Compare
experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl
Outdated
Show resolved
Hide resolved
experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl
Outdated
Show resolved
Hide resolved
Co-authored-by: Lars Kastner <[email protected]>
experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl
Outdated
Show resolved
Hide resolved
experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl
Outdated
Show resolved
Hide resolved
experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl
Outdated
Show resolved
Hide resolved
experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl
Outdated
Show resolved
Hide resolved
experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl
Outdated
Show resolved
Hide resolved
experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl
Outdated
Show resolved
Hide resolved
if m isa HypersurfaceModel | ||
cl = toric_divisor_class(ambient_space(m), degree(hypersurface_equation(m))) | ||
end | ||
cy = polynomial(cohomology_class(cl)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This same block of code appears in the calculations of c1, c2, the equality check for fluxes, and here. Perhaps we should make this its own function and store the result in an attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Or we add an attribute to Weierstrass and global Tate models that allows us to call hypersurface_equation in those cases to extract the value of weierstrass_polynomial
, respectively tate_polynomial
. I will try to remember this for a future PR.
Co-authored-by: Andrew P Turner <[email protected]>
Co-authored-by: Andrew P Turner <[email protected]>
A first implementation of G4-fluxes.