Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] Implement G4-fluxes #3965

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented Jul 23, 2024

A first implementation of G4-fluxes.

@HereAround HereAround marked this pull request as draft July 23, 2024 16:01
@HereAround HereAround force-pushed the G4Fluxes branch 3 times, most recently from 718df0d to 4e9180d Compare July 24, 2024 08:51
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 75.92593% with 26 lines in your changes missing coverage. Please review.

Project coverage is 84.32%. Comparing base (77a500e) to head (e6171e0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3965      +/-   ##
==========================================
- Coverage   84.33%   84.32%   -0.02%     
==========================================
  Files         593      596       +3     
  Lines       81750    81853     +103     
==========================================
+ Hits        68945    69022      +77     
- Misses      12805    12831      +26     
Files Coverage Δ
...perimental/FTheoryTools/src/G4Fluxes/attributes.jl 100.00% <100.00%> (ø)
experimental/FTheoryTools/src/types.jl 95.12% <100.00%> (+0.12%) ⬆️
...ometry/ToricVarieties/CohomologyClasses/methods.jl 61.53% <100.00%> (+1.53%) ⬆️
...cVarieties/CohomologyClasses/special_attributes.jl 100.00% <100.00%> (ø)
...perimental/FTheoryTools/src/G4Fluxes/properties.jl 90.47% <90.47%> (ø)
...heoryTools/src/AbstractFTheoryModels/attributes.jl 96.45% <85.71%> (-2.13%) ⬇️
...rimental/FTheoryTools/src/G4Fluxes/constructors.jl 40.00% <40.00%> (ø)

... and 1 file with indirect coverage changes

@HereAround HereAround force-pushed the G4Fluxes branch 3 times, most recently from cff46e1 to aed0131 Compare July 24, 2024 21:52
@HereAround HereAround force-pushed the G4Fluxes branch 5 times, most recently from 139470d to c69d956 Compare July 25, 2024 07:28
@HereAround HereAround marked this pull request as ready for review July 25, 2024 21:41
@HereAround HereAround requested a review from apturner July 25, 2024 21:41
if m isa HypersurfaceModel
cl = toric_divisor_class(ambient_space(m), degree(hypersurface_equation(m)))
end
cy = polynomial(cohomology_class(cl))
Copy link
Collaborator

@apturner apturner Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This same block of code appears in the calculations of c1, c2, the equality check for fluxes, and here. Perhaps we should make this its own function and store the result in an attribute.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Or we add an attribute to Weierstrass and global Tate models that allows us to call hypersurface_equation in those cases to extract the value of weierstrass_polynomial, respectively tate_polynomial. I will try to remember this for a future PR.

HereAround and others added 2 commits July 26, 2024 10:09
Co-authored-by: Andrew P Turner <[email protected]>
Co-authored-by: Andrew P Turner <[email protected]>
@HereAround HereAround enabled auto-merge (rebase) July 26, 2024 09:14
@HereAround HereAround merged commit f426155 into oscar-system:master Jul 26, 2024
23 of 26 checks passed
@HereAround HereAround deleted the G4Fluxes branch July 26, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants