Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing to 'nothing' should be done with === #43

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

fingolfin
Copy link
Member

... for better type stability

... for better type stability
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 6.50%. Comparing base (8ff8943) to head (d9117b5).

Files Patch % Lines
src/PrintToTex/PrimitiveRoot.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #43   +/-   ##
======================================
  Coverage    6.50%   6.50%           
======================================
  Files          60      60           
  Lines        8858    8858           
======================================
  Hits          576     576           
  Misses       8282    8282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fingolfin fingolfin merged commit 8528411 into master Mar 5, 2024
7 checks passed
@fingolfin fingolfin deleted the mh/nothing branch March 5, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant