HACK: add faster arithmetic for UnivPoly and ZZRingElem #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not meant to be merged, just serve as a reminder: arithmetic for UnivPoly could be quite a bit more efficient. The methods added here help concrete computations in the method
(R::GenericCycloRing)(f::Dict{UPolyFrac, UPoly}; simplify::Bool=true)
.But they are not going far enough and are incomplete. Someone should patch AA (and perhaps Nemo) to add...
add!
,sub!
,mul!
methods in AA looking like this:c
should be restricted to e.g.RingElement
but I think for this kind of fallback it has no advantage?)addmul!
(there also in the variant which takes threeUnivPoly
)add!
,sub!
,mul!
methods