Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: add comment that the files are generated #101

Merged

Conversation

schuellerf
Copy link
Contributor

added a reminder while trying to fix typos, not to change some of those *.mds ;)

This strange syntax seems to work as a comment which is not exported to the result for docusaurus and other markdown parsers

@schuellerf schuellerf force-pushed the add-comment-for-generated-content branch from 0f3aee2 to 2f33188 Compare July 31, 2024 16:32
@schuellerf schuellerf enabled auto-merge (rebase) August 1, 2024 12:38
@schuellerf schuellerf force-pushed the add-comment-for-generated-content branch from 2f33188 to ed91c22 Compare August 1, 2024 14:29
@schuellerf schuellerf force-pushed the add-comment-for-generated-content branch from ed91c22 to 06f29aa Compare August 13, 2024 08:21
supakeen
supakeen previously approved these changes Aug 13, 2024
Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is good (did this happen?). There's build failures going on though.

@schuellerf
Copy link
Contributor Author

build failure is due to osbuild/weldr-client#144 I guess. At least on my machine?!

@schuellerf schuellerf force-pushed the add-comment-for-generated-content branch 3 times, most recently from 72aa1d6 to cc56b1c Compare August 13, 2024 14:56
Copy link
Contributor

@ochosi ochosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice idea!

@ochosi ochosi force-pushed the add-comment-for-generated-content branch from cc56b1c to 4ae033e Compare August 13, 2024 21:20
@schuellerf schuellerf merged commit 6ffb4ff into osbuild:main Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants