blueprint: add cacert customization

[lzap]

This is a follow-up to

https://github.com/osbuild/images/pull/907/files

I am shooting in the dark, not sure how can I test this locally. Let me know how can I test this.

[avitova]

Few nitpicks I noticed.

[lzap]

Rebased, how about this? Anything else that needs to be done?

[thozza]

LGTM.

Could you please extend the Cloud API api.sh test case and at least one Weldr API test case (e.g. aws.sh) to use this customization? You can take a look at the following commit as an inspiration 768537d#diff-8c9fc1f11806f990402d945e7a6a3bdcf8be429120a4b8c2ec18e9ff5251f02f , but also extend the _instanceCheck() in https://github.com/osbuild/osbuild-composer/blob/main/test/cases/api/common/common.sh#L18

[avitova]

Thanks for the other PR, I am good here.

[lzap]

I see four people commenting, no formal review tho. Please give me the green light, enabled auto merge, thanks.

[thozza]

I see four people commenting, no formal review tho. Please give me the green light, enabled auto merge, thanks.

Consider my comment to be a formal review. I usually do not explicitly request changes, because it feels a bit rough, compared to just making a comment.

[lzap]

Rebased, how about this.

[avitova]

I am good here, but let's wait for others to approve too. :)

[lzap]

I changed the test case to grep the concatenated bundle instead of trying to find the cert copy in directory-hash. I have learned that this directory is not present on older RHEL systems so this way the test will pass everywhere. Rebased.

[thozza]

LGTM.
Thank you!

CI is failing

[thozza]

@lzap you need to append ${CACERTS_CUSTOMIZATION_BLOCK} also in:

• https://github.com/osbuild/osbuild-composer/blob/main/test/cases/api/gcp.sh#L75
• https://github.com/osbuild/osbuild-composer/blob/main/test/cases/api/oci.sh#L80

[lzap]

RIght, added, rebased, no changes. Thanks for help with both! :-D