Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud API: Add Fedora IoT bootable container #3916

Merged

Conversation

achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Jan 26, 2024

Add the Fedora iot-bootable-container to the cloud API and include it in the API tests.
See osbuild/images#361 for image definition introduction.

We don't intend to have this available in osbuild-composer on-prem (Weldr), so it's added to the deny list.


This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@achilleas-k achilleas-k force-pushed the cloudapi/fedora-iot-bootable-container branch from 4019ec3 to 32d3dba Compare January 26, 2024 14:26
ondrejbudai
ondrejbudai previously approved these changes Jan 26, 2024
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

thozza
thozza previously approved these changes Jan 26, 2024
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achilleas-k achilleas-k dismissed stale reviews from thozza and ondrejbudai via 1f5e09d January 26, 2024 14:58
@achilleas-k achilleas-k force-pushed the cloudapi/fedora-iot-bootable-container branch from 32d3dba to 1f5e09d Compare January 26, 2024 14:58
@achilleas-k
Copy link
Member Author

Missed a denylist test. Fixed.

thozza
thozza previously approved these changes Jan 26, 2024
@achilleas-k achilleas-k force-pushed the cloudapi/fedora-iot-bootable-container branch from 1f5e09d to 8ac2a25 Compare January 29, 2024 13:28
ondrejbudai
ondrejbudai previously approved these changes Jan 30, 2024
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@ondrejbudai ondrejbudai enabled auto-merge (rebase) January 30, 2024 11:50
@achilleas-k achilleas-k force-pushed the cloudapi/fedora-iot-bootable-container branch 2 times, most recently from 9dbb0dc to b29e766 Compare January 30, 2024 16:58
@achilleas-k
Copy link
Member Author

achilleas-k commented Jan 30, 2024

Cherry-picked the two commits from #3919 for CI fixage.

The image type supports uploading to both s3 and container registries.
Right now we only care about getting it in Koji, so let's just add it to
the s3 upload section.

The container registry test also embeds containers in the image, which
the iot-bootable-container doesn't support (yet).
Required for bootc for iot-bootable-container.
We only want to build this image type in Fedora Koji.
@achilleas-k achilleas-k force-pushed the cloudapi/fedora-iot-bootable-container branch from b29e766 to 2c22104 Compare January 31, 2024 09:20
@achilleas-k
Copy link
Member Author

Most CI failures are now related to an RHOS-01 outage.
There's also two Azure failures. Not sure what's wrong with those.

@ondrejbudai ondrejbudai merged commit 3e31ebf into osbuild:main Feb 2, 2024
70 of 72 checks passed
@achilleas-k achilleas-k deleted the cloudapi/fedora-iot-bootable-container branch February 2, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants