Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add custom partition mount points to raw image test case #3884

Closed

Conversation

mcattamoredhat
Copy link
Contributor

This pull request includes:

This PR adds custom partitions to blueprint of edge-raw-image, making use of the example comments at RHEL 9: Filesystem customizations for edge-raw-image

A playbook task has been included to check the custom partitions using lvdisplay

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@mcattamoredhat mcattamoredhat added the WIP Work in progress. Don't run Gitlab CI. label Jan 8, 2024
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch 3 times, most recently from a3ef38e to e0c8440 Compare January 10, 2024 10:05
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch from e0c8440 to 92126d2 Compare January 10, 2024 13:03
@say-paul
Copy link
Member

lets hold this off until osbuild/images#352 is resolved

@mcattamoredhat mcattamoredhat changed the title test: add custom lvs to edge-raw-image test case test: add custom partition mount points to edge-raw-image test case Jan 19, 2024
djach7
djach7 previously approved these changes Jan 22, 2024
Copy link
Contributor

@djach7 djach7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reviewed for English conventions with basic go knowledge

@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch from 92126d2 to 4aeedcd Compare January 26, 2024 12:15
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch 5 times, most recently from 512d13c to bbfaee3 Compare February 2, 2024 16:47
@mcattamoredhat mcattamoredhat changed the title test: add custom partition mount points to edge-raw-image test case test: add custom partition mount points to raw image test case Feb 2, 2024
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch from bbfaee3 to 7a26de2 Compare February 5, 2024 13:26
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch 3 times, most recently from 1bc2e36 to d1668d0 Compare February 19, 2024 14:52
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch from d1668d0 to a299598 Compare February 21, 2024 11:35
Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 23, 2024
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch 2 times, most recently from 279b0cd to f81b03b Compare April 1, 2024 14:54
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch 2 times, most recently from 656ff80 to 4f09ab6 Compare April 10, 2024 09:39
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch 4 times, most recently from 18ebdb2 to bc3cc3c Compare April 18, 2024 09:34
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch from bc3cc3c to b91db65 Compare April 30, 2024 08:38
Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 31, 2024
Copy link

github-actions bot commented Jun 7, 2024

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Jun 7, 2024
@mcattamoredhat mcattamoredhat reopened this Aug 6, 2024
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch 2 times, most recently from c51eaff to 71675d0 Compare August 14, 2024 09:43
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch 2 times, most recently from e90886e to 392761c Compare August 20, 2024 15:05
@mcattamoredhat mcattamoredhat marked this pull request as ready for review August 20, 2024 15:15
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch from 392761c to bd66f78 Compare August 29, 2024 12:53
@mcattamoredhat mcattamoredhat force-pushed the fs-custom-lvs-raw-image branch from bd66f78 to 2447408 Compare September 4, 2024 14:14
Copy link

github-actions bot commented Oct 5, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 5, 2024
Copy link

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale WIP Work in progress. Don't run Gitlab CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants