osbuildmonitor: add new package to monitor osbuild output #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains an abreviated version of an osbuild jsonseq output log. Most of the repetitive data from the curl and rpm stages got removed as they don't add (much) to the understanding. The data was generated via: ``` $ sudo python3 -m osbuild --libdir . --monitor JSONSeqMonitor \ --export image --output-directory /tmp/out \ ./test/data/manifests/fedora-boot.json > osbuild-status-output.json ```
This commit adds support for the jsonseq based monitoring that osbuild provides. This is useful for machine readable status reporting.
This commit adds a `Status.Trace` string in the osbuildmonitor. Trace contains a single log line, usually very low-level or stage output bug useful for e.g. bug reporting. Should in general not be displayed to the user but the concatenation of all "trace" lines should give the same information as running osbuild on a terminal.
This commit adds `Status.Timestamp` so that it's easier to correlate what took how long when reconstructing the log (e.g. for bugreporting). See also: https://github.com/osbuild/images/compare/main...mvo5:osbuildmonitor-testdata?expand=1 for the full log.
mvo5
force-pushed
the
osbuildmonitor-pkg
branch
from
1b72324
to
f09dee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft until I have integrated this into either ibuilder(image-builder-cli)/bootc-image-builder) to show that it has no gaps, but wanted to show it here for early feedback]
This commit adds support for the jsonseq based monitoring that
osbuild provides. This is useful for human/machine readable status
reporting.
Note that the provided information is intentionally small right now,
we will need to go over the osbuild implementation and cleanup
some of the reporting, especially around error reporting from osbuild
(see osbuild/osbuild#1831).
The two main use-cases this should cover right now: