Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install anaconda-install-img-deps package in anaconda installers. #1031

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mmartinv
Copy link
Contributor

According to the anaconda team we should be using the anaconda-install-img-deps
metapackage to install all the boot.iso image dependencies.

Relates: fedora-iot/iot-distro#66
Signed-off-by: Miguel Martín [email protected]

According to the anaconda team we should be using the `anaconda-install-img-deps`
metapackage to install all the boot.iso image dependencies.

Relates: fedora-iot/iot-distro#66
Signed-off-by: Miguel Martín <[email protected]>
Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going by the descriptions of these packages anaconda-install-img-deps is indeed the correct dependency (and it in turn depends on anaconda-install-env-deps). Ack.

@supakeen supakeen added this pull request to the merge queue Nov 11, 2024
@mvo5 mvo5 requested a review from thozza November 11, 2024 12:55
@thozza
Copy link
Member

thozza commented Nov 11, 2024

Note that this needs to be fixed also on RHEL-9 and older since I made the change for RHEL-10 when adding the image-installer img type. Unfortunately, I didn't get to verify if the package is present on all older RHEL versions.

Consequently, this change means that a bunch of other packages can be removed from the pkg list, and we do not need to list them explicitly (as these are pulled in as anaconda-install-img-deps dependency). Based on my previous work, these are mostly some UI-related dependencies.

Merged via the queue into osbuild:main with commit 4897f61 Nov 11, 2024
19 checks passed
@mmartinv
Copy link
Contributor Author

Note that this needs to be fixed also on RHEL-9 and older since I made the change for RHEL-10 when adding the image-installer img type. Unfortunately, I didn't get to verify if the package is present on all older RHEL versions.

Just checked and it's present in RHEL 8 and RHEL 9

Consequently, this change means that a bunch of other packages can be removed from the pkg list, and we do not need to list them explicitly (as these are pulled in as anaconda-install-img-deps dependency). Based on my previous work, these are mostly some UI-related dependencies.

Yes, we can do a follow up PR to remove the unneeded deps I guess, the dependencies for both metapackages in Fedora 42 are currently:

sudo dnf repoquery --requires anaconda-install-img-deps anaconda-install-env-deps
Updating and loading repositories:
Repositories loaded.
anaconda-install-env-deps = 42.13-1.fc42
brltty
btrfs-progs
createrepo_c
device-mapper-multipath
dosfstools
e2fsprogs
f2fs-tools
fcoe-utils >= 1.0.12-3.20100323git
gdb
gnome-kiosk
gnome-remote-desktop
gsettings-desktop-schemas
hfsplus-tools
isomd5sum >= 1.0.10
kdump-anaconda-addon
kexec-tools
libblockdev-lvm-dbus
libblockdev-plugins-all >= 2.1
librsvg2
mesa-dri-drivers
nm-connection-editor
ntfs-3g
ntfsprogs
nvme-cli
openssl
ostree
podman
python3-pam
realmd
rpm-ostree >= 2023.2
rsync
skopeo
tmux
udisks2-iscsi
xfsprogs
zram-generator-defaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants