Minor notebook cleanups to make TPI nb more consistent with OECM nb #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ModeSevenIndustrialSolutions can you take a look at the failing black-nb and pydocstyle problems? Somehow, also, the security-related build/audit is failing for reasons I don't understand. |
…M notebook. Also commit changed to XLSX benchmark data (which is not formally used by ITR project, though it could be). Update dependencies as pandas>=2.2 requires openpyxl>=3.1.0 Disable pydocstyle D100 in empty file make_dataset.py Comment out black-nb until we have a better notebook linting tool. Don't count empty files in coverage report. Update versions for osc-ingest-tools, openscm-units, and iam-units. Finish cleaning up tpi-cleanup changes. We can now run both OECM and TPI benchmark notebooks. An outstanding question: do we really need to create two separate venvs for tox (one for `tests` and one for `notebooks`) or can we find a better way to control how `pytest` is activated? Add test_trivial.py so pytest can find it and CI/CD can pass. Signed-off-by: Michael Tiemann <[email protected]>
MichaelTiemannOSC
force-pushed
the
tpi-cleanup
branch
from
e1c82fd
to
0cc9419
Compare
incorporates devops changes to better control Jupyter Notebook tests. From here on out, notebooks to be tested must be prefixed with test_ just like unit tests need a test_ prefix for pytest to run them. Signed-off-by: Michael Tiemann <[email protected]>
MichaelTiemannOSC
force-pushed
the
tpi-cleanup
branch
from
0f8f76f
to
51de8f8
Compare
ModeSevenIndustrialSolutions
merged commit 8b15070
into
os-climate:main
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor notebook cleanups to make TPI notebook more consistent with OECM notebook.
Also commit changed to XLSX benchmark data (which is not formally used by ITR project, though it could be).