Fix and test perlcritic plugins #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
force-pushed
the
perlcritic-plugins
branch
from
36b17d3 to
faa3429
Compare
perlpunk
force-pushed
the
perlcritic-plugins
branch
from
faa3429 to
4fcb716
Compare
perlpunk
force-pushed
the
perlcritic-plugins
branch
from
4fcb716 to
0c2190a
Compare
okurz
requested changes
Aug 13, 2024
perlpunk
force-pushed
the
perlcritic-plugins
branch
from
0c2190a to
3968962
Compare
okurz
approved these changes
Aug 13, 2024
kalikiana
approved these changes
Aug 13, 2024
b10n1k
reviewed
Aug 13, 2024
Comment on lines
+71
to
+72
| my $nsib = $elem->snext_sibling; | ||
| my $psib = $elem->sprevious_sibling; |
There was a problem hiding this comment.
are those two used somewhere?
b10n1k
reviewed
Aug 13, 2024
| @@ -77,7 +79,8 @@ sub _is_block ($token) { | |||
| } | |||
|
|
|||
| sub _is_only_one_space ($token) { | |||
| return $token->isa('PPI::Token::Whitespace') && $token->content eq ' '; | |||
| # We also allow line breaks, e.g. perltidy forces to break up long subroutine headers | |||
| return $token->isa('PPI::Token::Whitespace') && $token->content =~ m/^[ \n]$/; | |||
There was a problem hiding this comment.
Do we need a better function name? Maybe is_whitespace_or_newline? but not sure
|
I was too late. But if you dont mind take a look on my comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds proper unit tests to our perlcritic plugins and fixes some of them.
It also adds the
OpenQAnamespace to the plugin names.I ran it on openQA and os-autoinst now.
For RedundantStrictWarning we will need a couple of
## no critic comments. there's no way to disable a plugin from the config file apparently. Reducing the severity will still exit with non-zero.Issue: https://progress.opensuse.org/issues/155188