Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authortests workflow #47

Closed
wants to merge 2 commits into from

Conversation

perlpunk
Copy link
Collaborator

@perlpunk perlpunk commented Feb 7, 2024

No description provided.

If it failed because of permissions then `@status` would still have been
empty and the test was passing.
steps:
- uses: actions/checkout@v4
- run: git config --global --add safe.directory '*'
- run: prove xt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to pile up more github action specific implementations because then developers won't know how to run all tests and checks locally, see #46

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, maybe we shouldn't work on this in parallel with 3 persons...

@perlpunk
Copy link
Collaborator Author

perlpunk commented Feb 7, 2024

Then please add this workflow to your PR.
The workflow is missing, we need to check that make update-deps is succesful.

@perlpunk perlpunk closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants