Add unittests #29
Draft
Add unittests #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for Condition class
strump
commented
Nov 19, 2024
| @@ -24,7 +24,7 @@ def __init__(self, typez, params): | |||
| params = (params,) | |||
| self.params = params # e.g. ('highway','primary') | |||
| if typez == "regex": | |||
| self.regex = re.compile(self.params[0], re.I) | |||
| self.regex = re.compile(self.params[1], re.I) | |||
There was a problem hiding this comment.
Here I fixed bug with regex conditions: [natural=~/water.+/]. Organic Maps never used such conditions in MapCSS styles.
Should we remove regex conditions completely from the kothic?
strump
force-pushed
the
add-unittests
branch
from
26c73f6
to
7b39eae
Compare
strump
force-pushed
the
add-unittests
branch
from
1fab805
to
4adcd77
Compare
strump
commented
Nov 20, 2024
| import logging | ||
|
|
||
| logger = logging.getLogger('mapcss.Eval') | ||
| logger.setLevel(logging.ERROR) | ||
|
|
||
| class Eval(): |
There was a problem hiding this comment.
This class is responsible for eval(...) expressions in .mapcss files. But Organic Maps never used evals in styles.
Should we remove eval completely from the project?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kothicwith unittestsf""stringsHere I'm covering all base classes
Rule,Condition,MapCSS,Eval,libkomwm.pywith unit-tests to make sure nothing will brake on new changes.Work in progress.