Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated protobuf to 4.24.4 #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updated protobuf to 4.24.4 #27

wants to merge 1 commit into from

Conversation

biodranik
Copy link
Member

@biodranik biodranik requested a review from vng October 15, 2023 07:28
@biodranik biodranik mentioned this pull request Oct 15, 2023
Open
pastk
pastk approved these changes Oct 15, 2023
View reviewed changes
README.md Outdated
@@ -7,3 +7,5 @@ Python dependencies:
```bash
pip3 install -r requirements.txt
```

Updating protobuf in the repo should be synced with Kothik.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Updating protobuf in the repo should be synced with Kothik.
Updating protobuf in the repo should be synced with Kothic.

@biodranik
Updated protobuf to 4.24.4
2260f36 
Signed-off-by: Alexander Borsuk <[email protected]>
@biodranik
Copy link
Member Author

biodranik commented Oct 15, 2023 •
edited
Loading

@pastk regenerating drules with newer protobuf from this branch doesn't show any local changes. Is it expected?

@pastk
Copy link
Collaborator

pastk commented Oct 15, 2023

Looks like the binary format didn't change (at least in the part used by us).

@pastk
Copy link
Collaborator

pastk commented May 9, 2024

@AndrewShkrob There is a tools/python/stylesheet/drules_struct_pb2.py file in the main repo which hasn't been updated accordingly, this versions discrepancy is likely causing organicmaps/organicmaps#8113 (comment)

Probably all scripts should be changed to use the drules_struct_pb2.py file from the kothic repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pastk pastk pastk approved these changes

@vng vng Awaiting requested review from vng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biodranik @pastk