Prevent CSRF token from being leaked to cross-origin requests #2889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code inside the html_load_controller.js makes the CSRF token being sent to every Axios and Turbo request:
platform/resources/js/controllers/html_load_controller.js
Lines 41 to 46 in 7e63b9c
This, however, leaks the token to cross-origin requests as well, defeating the whole purpose of CSRF protection.
This fix prevents the token from being leaked to cross-origin requests.
For Axios, it is certain that it needs to be implemented. For Turbo, I'm not sure the "turbo:before-fetch-request" is triggered during cross-origin requests, but I added the fix there as well, just in case.