Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change of the response format: added id and type in place of entityId and entityType #754

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

pooja1pathak
Copy link
Collaborator

Proposed changes

added id and type in place of entityId and entityType. Fix for issue #751

Types of changes

What types of changes does your code introduce to the project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have run all the existing tests locally (not just those related to my feature) and there are no errors
  • After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
  • I have updated the RELEASE NOTES
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

github-actions bot commented Mar 15, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@c0c0n3
Copy link
Member

c0c0n3 commented Apr 17, 2024

@pooja1pathak thanks for this PR :-)

Can you please confirm you've run the whole test suite, not just the reporter's one? At the moment the CircleCI runner is broken and I haven't managed to run the tests on my laptop.

Also, can you please add a backward-compatibility notice in the release notes along the lines of this one:

thanks so much!

@pooja1pathak
Copy link
Collaborator Author

@c0c0n3 I have updated the PR as per your comment. I have run all the tests locally and also checked the CircleCI. Please find below screenshot of the same:

image

Only test_others is failing, which is not related to my change as you can see in below screenshot:
image

Can we open new issue for this test_others failure and resolve this error?

Please let me know if any other change is required in this PR.

@c0c0n3 c0c0n3 merged commit 270a4e2 into orchestracities:master Apr 19, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
@c0c0n3
Copy link
Member

c0c0n3 commented Apr 19, 2024

@pooja1pathak thanks so much! I've just merged your PR into the main branch. If I could ask you one last favour: can you please open an issue about the failing geocoding test in test_others? Many thanks!!

@pooja1pathak pooja1pathak deleted the issue751 branch April 19, 2024 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants