Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #343 #504

Merged
merged 7 commits into from
Aug 13, 2021
Merged

Fix for Issue #343 #504

merged 7 commits into from
Aug 13, 2021

Conversation

daminichopra
Copy link
Contributor

Proposed changes

Added description as described in Issue

Types of changes

What types of changes does your code introduce to the project: Put
an x in the boxes that apply

  • [ x ] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask. We're here to help! This is simply a reminder of what we are going
to look for before merging your code.

  • [ x ] I have read the CONTRIBUTING doc
  • [ x ] I have signed the CLA
  • I have added tests that prove my fix is effective or that my
    feature works
  • [ x ] I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in
    downstream modules

Further comments

Added documentation as per Issue

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@daminichopra
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@chicco785 chicco785 changed the title Fix for Issue#343 Fix for Issue #343 Aug 12, 2021
docs/manuals/admin/crate.md Outdated Show resolved Hide resolved
docs/manuals/user/index.md Outdated Show resolved Hide resolved
src/reporter/delete.py Outdated Show resolved Hide resolved
@chicco785
Copy link
Contributor

@daminichopra if you are not able to clean up the branch from unrelated commits, i will create a new pr for you, let me know.

@daminichopra
Copy link
Contributor Author

@daminichopra if you are not able to clean up the branch from unrelated commits, i will create a new pr for you, let me know.

@chicco785 , Yes my branch has issues .....thanks for this suggestion .

@chicco785 chicco785 merged commit 35d3b93 into orchestracities:master Aug 13, 2021
@chicco785 chicco785 deleted the Issue#343 branch August 13, 2021 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants