Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Orion sidecar tale of woe #36

Merged
merged 8 commits into from
Apr 21, 2020
Merged

The Orion sidecar tale of woe #36

merged 8 commits into from
Apr 21, 2020

Conversation

c0c0n3
Copy link
Member

@c0c0n3 c0c0n3 commented Apr 20, 2020

This PR works out the issues we've been having with the Orion sidecar as documented by #28.
We can now run Orion as a mesh service with an Istio sidecar. Notice our (test) mesh configuration doesn't include any

  1. Orion/MongoDB initialisation---DB indexes, etc.
  2. Robust handling of start-up race conditions---see The Orion sidecar tale of woe #28 about it.

(1) is quite hard to do with an Orion init container as we do in Orchestra since we've got the sidecar in between with its own init container. Doing it without an Orion init container is possible but then we'll have to deal with race conditions.

We've introduced a 10 second delay before starting Orion to make it less likely to get race conditions at start-up---yep, poor's man approach to concurrency. So we can't claim we've got a robust solution for that.

We should make (1) and (2) visible to mesh admins so that they can roll out their own solution, e.g. readiness/liveness probes to make Orion bounce back after a startup failure---see #28 about it.

@c0c0n3 c0c0n3 merged commit 447f439 into master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant