Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works out the issues we've been having with the Orion sidecar as documented by #28.
We can now run Orion as a mesh service with an Istio sidecar. Notice our (test) mesh configuration doesn't include any
(1) is quite hard to do with an Orion init container as we do in Orchestra since we've got the sidecar in between with its own init container. Doing it without an Orion init container is possible but then we'll have to deal with race conditions.
We've introduced a 10 second delay before starting Orion to make it less likely to get race conditions at start-up---yep, poor's man approach to concurrency. So we can't claim we've got a robust solution for that.
We should make (1) and (2) visible to mesh admins so that they can roll out their own solution, e.g. readiness/liveness probes to make Orion bounce back after a startup failure---see #28 about it.