Splashscreen customization #496
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why should this wait for after the 2024 release? Seems like a relatively minor feature in terms of code, but would be really cool to have. |
|
We need to freeze features or we'll never release a new version... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should probably wait for after the 2024 release.
It adds support for custom load screens via a new scenario parameter "SplashScreen" in the ENVIRONMENT section :
BEGIN_ENVIRONMENT
System Sol
Date MJD 51982.0975169074
SplashScreen 0x0000ff Images/myawesomelogo.jpg
END_ENVIRONMENT
First parameter is a color in 0xbbggrr format, followed by the image filename to be shown on the splashscreen
Since I was messing with State.h, I took the opportunity to replace the error prone char arrays with std::string