exclude non-64-bit-modules from 64 bit builds #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know when this is ready for merge. |
| @@ -28,6 +28,7 @@ set_target_properties(${CELBODY} | |||
| FOLDER Celbody | |||
| ) | |||
|
|
|||
| if(NOT CMAKE_CL_64) #remove me when this celbody has source code that can be built | |||
There was a problem hiding this comment.
We have BUILD64 macro in root CMakeLists.txt - worth using that for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix to make 64-bit builds usable "out of the box" without commenting out anything in sol.cfg
closes #243
closes #353
This is not a replacement for the missing modules. It just prevents CMAKE from packaging non-working 32-bit DLLs with OOx64