New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize basic math types and functions (part 5) #372

Draft

dimitry-ishenko wants to merge 120 commits into orbitersim:main from dimitry-ishenko-orbiter:math5

Contributor

dimitry-ishenko commented Jul 14, 2023

This is a fifth in a series of PRs meant clean up and centralize basic math constants, vectors and matrices. Currently these are scattered all over the project and many of them have overlapping functionality.

For example, there are VECTOR3 and VECTOR4 types defined in the SDK (the OrbiterAPI.h file). Then there are Vector and Vector4 types defined in the Orbiter (the Vecmat.h file). There are also FVECTOR3 and FVECTOR4 which are equivalents of VECTOR3 and VECTOR4 but with the float data type. Each one of these classes overloads their own set of operators and defines their own versions of different functions. This results in messy and duplicate code.

Similar situation exists for the matrices, and simple math constants eg, 𝜋, etc.)

The plan is to unite all these types and define a set of operator and function templates that are uniform and are shared by all these types. The steps are:

dimitry-ishenko added 30 commits

July 12, 2023 11:22


          OrbiterAPI.h: few small clean-ups


          DrawAPI.h: remove DirectX 9 specific conversions

Move them into the D3D9Client.


          Add template operators and functions for vectors

e5dc319


          Add stream operators for vectors

f8dcfbf


          Add pow() for vectors

d592df8


          Add exp(), lerp() and sqrt() for vectors

0f3080e


          Templatize saturate()

370cde2


          Centralize VECTOR4

890ea9e


          Centralize VECTOR3

93ceb2f


          Remove VectorHelpers.h

34229aa

Some of the functions were taken over by the new vector templates.
Others were removed or absorbed into D3D9Util.h.


          Clean-up

cc2e1a4

Remove unnecessary _V().
Use new vector functions.


          LuaInterpreter: clean-up

bd4b66e

Remove unnecessary _V().
Use new vector functions.


          ScnEditor: Clean-up

75d6e61

Remove unnecessary _V().


          TransX: clean-up

fd1faa4

Remove unnecessary _V().
Use new vector functions.


          Atlantis: clean-up

8954b21

Remove unnecessary _V().
Use new vector functions.


          DeltaGlider: clean-up

69daccc

Remove unnecessary _V().
Use new vector functions.


          DragonFly: clean-up

3c40cde

Remove unnecessary _V().


          HST: clean-up

a69d576

Remove unnecessary _V().


          MMU: clean-up

e5911f7

Remove unnecessary _V().


          Quadcopter: clean-up

a6d5295

Remove unnecessary _V().
Use new vector functions.


          ShuttleA: clean-up

4c6493b

Remove unnecessary _V().


          ShuttlePB: clean-up

6f21191

Remove unnecessary _V().


          Solarsail: clean-up

429d12f

Remove unnecessary _V().
Use new vector functions.


          XRSound: clean-up

Remove unnecessary _V().


          D3D7Client: clean-up

839724f

Remove unnecessary _V().
Use new vector functions.


          D3D9Client: clean-up

479a130

Remove unnecessary _V().
Use new vector functions.


          DrawOrbits: clean-up

031394e

Remove unnecessary _V().
Use new vector functions.


          GenericCamera: clean-up

d7057c0

Remove unnecessary _V().


          TerrainToolBox: clean-up

c437e8e

Remove unnecessary _V().
Use new vector functions.


          OrbiterAPI.h: remove unused VECTOR3 functions

5f4ee84

dimitry-ishenko added 29 commits

July 12, 2023 11:22


          Baseobj: post-Vector clean-up

c21963e


          FlightRecorder: post-Vector clean-up

370637d


          hud: post-Vector clean-up

255fa32


          MfdAlign: post-Vector clean-up

c1183e4


          MfdMap_old: post-Vector clean-up

2f5bdec


          MfdTransfer: post-Vector clean-up

ed62d99


          Psys: post-Vector clean-up

fccfab7


          Rigidbody: post-Vector clean-up

df606af


          Scene: post-Vector clean-up

b7ee1d3


          Spherepatch: post-Vector clean-up

b133cba


          SuperVessel: post-Vector clean-up

8d553a0


          tilelabel: post-Vector clean-up

05908a0


          tilemgr2: post-Vector clean-up


          VCockpit: post-Vector clean-up

8e2b13c


          VectorMap: post-Vector clean-up

bf7af48


          Vessel: post-Vector clean-up

3d8a590


          Vesselstatus: post-Vector clean-up

d7c063e


          Shipedit: post-Vector clean-up


          Centralize FVECTOR2

For now it is kept inside the oapi namespace so as to keep compatibility
with the existing addons.


          vector.h: tighten up template params

a4a452c


          Enable vector conversions


          Use len() where possible

268d422


          Centralize COLOUR3 and COLOUR4

ee78887


          Add color conversion functions

6a713d2


          Add max_rgb functions for colors and vectors

308aa52


          Give FVECTOR3 is_vector3 type trait

8cdd870


          D3D9Client: clean-up & use standard functions

2d948a7


          Atlantis: clean-up

e590a91


          Centralize FVECTOR3

95ce14c

dimitry-ishenko force-pushed the math5 branch from 9527be3 to 95ce14c Compare

July 14, 2023 20:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet