New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize basic math types and functions (part 3) #370

Draft

dimitry-ishenko wants to merge 90 commits into orbitersim:main from dimitry-ishenko-orbiter:math3

Contributor

dimitry-ishenko commented Jul 14, 2023

This is a third in a series of PRs meant clean up and centralize basic math constants, vectors and matrices. Currently these are scattered all over the project and many of them have overlapping functionality.

For example, there are VECTOR3 and VECTOR4 types defined in the SDK (the OrbiterAPI.h file). Then there are Vector and Vector4 types defined in the Orbiter (the Vecmat.h file). There are also FVECTOR3 and FVECTOR4 which are equivalents of VECTOR3 and VECTOR4 but with the float data type. Each one of these classes overloads their own set of operators and defines their own versions of different functions. This results in messy and duplicate code.

Similar situation exists for the matrices, and simple math constants eg, 𝜋, etc.)

The plan is to unite all these types and define a set of operator and function templates that are uniform and are shared by all these types. The steps are:

Define operator and function templates for vectors.
Centralize VECTOR4 type.
Centralize VECTOR3 type.
Merge Vector4 and VECTOR4.
Merge Vector and VECTOR3.

dimitry-ishenko added 30 commits

July 12, 2023 11:22


          OrbiterAPI.h: few small clean-ups


          DrawAPI.h: remove DirectX 9 specific conversions

Move them into the D3D9Client.


          Add template operators and functions for vectors

e5dc319


          Add stream operators for vectors

f8dcfbf


          Add pow() for vectors

d592df8


          Add exp(), lerp() and sqrt() for vectors

0f3080e


          Templatize saturate()

370cde2


          Centralize VECTOR4

890ea9e


          Centralize VECTOR3

93ceb2f


          Remove VectorHelpers.h

34229aa

Some of the functions were taken over by the new vector templates.
Others were removed or absorbed into D3D9Util.h.


          Clean-up

cc2e1a4

Remove unnecessary _V().
Use new vector functions.


          LuaInterpreter: clean-up

bd4b66e

Remove unnecessary _V().
Use new vector functions.


          ScnEditor: Clean-up

75d6e61

Remove unnecessary _V().


          TransX: clean-up

fd1faa4

Remove unnecessary _V().
Use new vector functions.


          Atlantis: clean-up

8954b21

Remove unnecessary _V().
Use new vector functions.


          DeltaGlider: clean-up

69daccc

Remove unnecessary _V().
Use new vector functions.


          DragonFly: clean-up

3c40cde

Remove unnecessary _V().


          HST: clean-up

a69d576

Remove unnecessary _V().


          MMU: clean-up

e5911f7

Remove unnecessary _V().


          Quadcopter: clean-up

a6d5295

Remove unnecessary _V().
Use new vector functions.


          ShuttleA: clean-up

4c6493b

Remove unnecessary _V().


          ShuttlePB: clean-up

6f21191

Remove unnecessary _V().


          Solarsail: clean-up

429d12f

Remove unnecessary _V().
Use new vector functions.


          XRSound: clean-up

Remove unnecessary _V().


          D3D7Client: clean-up

839724f

Remove unnecessary _V().
Use new vector functions.


          D3D9Client: clean-up

479a130

Remove unnecessary _V().
Use new vector functions.


          DrawOrbits: clean-up

031394e

Remove unnecessary _V().
Use new vector functions.


          GenericCamera: clean-up

d7057c0

Remove unnecessary _V().


          TerrainToolBox: clean-up

c437e8e

Remove unnecessary _V().
Use new vector functions.


          OrbiterAPI.h: remove unused VECTOR3 functions

5f4ee84

dimitry-ishenko added 30 commits

July 12, 2023 11:22


          OrbiterAPI: clean-up

d34004a


          Pane: clean-up & use standard functions/operators

2444a8d


          PinesGrav: use standard functions/operators

f0999cf


          Planet: clean-up & use standard functions/operators

2f71ff7


          Psys: clean-up & use standard functions/operators

e413c07


          Rigidbody: clean-up & use standard functions/operators

f428815


          Scene: clean-up & use standard functions/operators

b46b669


          Spherepatch: clean-up & use standard functions/operators

17aedf1


          SuperVessel: clean-up & use standard functions/operators

571654f


          surfmgr2: use standard functions/operators

9bb80d6


          tilelabel: clean-up & use standard functions/operators

3a3d542


          TileMgr: clean-up & use standard functions/operators

f501838


          tilemgr2: clean-up & use standard functions/operators

801eaef


          VBase: clean-up & use standard functions/operators

a2e9b59


          VCockpit: clean-up & use standard functions/operators

f6f1f5e


          VectorMap: clean-up

b0fe1b2


          Vessel: clean-up & use standard functions/operators

e63c7e3


          Vesselbase: clean-up & use standard functions/operators

e30d39b


          Vesselstatus: clean-up & use standard functions/operators

0a89bc1


          Vobject: clean-up & use standard functions/operators

6b8f8c7


          VPlanet: clean-up & use standard functions/operators

46bebaf


          Vstar: clean-up & use standard functions/operators

8e19805


          Vvessel: clean-up & use standard functions/operators

1b21c7d


          Shipedit: clean-up & use standard functions/operators

3c14ddf


          Vector: remove unnecessary functions and operators

16ce7c5

These have now been replaced by the standard function and operator
templates in vector.hpp.


          De-unionize TILEBOUNDS

0b0cd3e

There is only one place where it's used as a vector and for that I've
added the to_VECTOR4 function.


          VECTOR4: 0-init by default

b2c9fc7

This is to be consistent wit other vector types.


          Add ctor to MESHGROUP_TRANSFORM

44d4fcb

This is needed in preparation for VECTOR3 update.


          VECTOR3: 0-init by default

310fb23

This is to be consistent wit other vector types and will also allow us
to merge it with the Vector class.


          Replace Vector with VECTOR3

6be5f68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet