Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sinks): enable sinks with noauth. #2857

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

lpegoraro
Copy link
Contributor

@lpegoraro lpegoraro commented Dec 8, 2023

TODOs

  • Integration test on local machine

Enable sinks to be configured withou username/password.

When creating sinks with NoAuth using the following sample configuration.

authentication:
  type: noauth
exporter:
  remote_host: https://localhost:6657

would generate the following otel collector.

---
receivers:
  kafka:
    brokers:
    - kafka:9092
    topic: otlp_metrics-sink-id-22
    protocol_version: 2.0.0
extensions:
  pprof:
    endpoint: 0.0.0.0:1888
exporters:
  otlphttp:
    endpoint: https://localhost:6657
service:
  extensions:
  - pprof
  pipelines:
    metrics:
      receivers:
      - kafka
      exporters:
      - otlphttp

Results
Sink is created successfully
image

Maestro is able to spin collector succesfully without the basicauth extension.
image

@lpegoraro lpegoraro self-assigned this Dec 8, 2023
@github-actions github-actions bot added the golang label Dec 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (583c5fd) 48.53% compared to head (6f968ae) 57.99%.
Report is 10 commits behind head on develop.

Files Patch % Lines
maestro/deployment/service.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2857      +/-   ##
===========================================
+ Coverage    48.53%   57.99%   +9.46%     
===========================================
  Files           85       67      -18     
  Lines         6330     5216    -1114     
===========================================
- Hits          3072     3025      -47     
+ Misses        3258     2191    -1067     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpegoraro lpegoraro marked this pull request as ready for review December 11, 2023 14:50
@lpegoraro lpegoraro marked this pull request as draft December 11, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants