bootstrap-coa-env(*) #164

lucaspinto · 2018-07-11T09:34:31Z

Fixes #113 .

Changes proposed in this pull-request:

adds a script called "bootstrap_coa_env.rb" that, when fed a list of prerequisites credentials, creates a minimal COA environment.

lucaspinto · 2018-07-11T09:35:18Z

docs/reference_dataset/pipelines/hello-world-root-depls-generated.yml

@@ -75,7 +75,7 @@ resources:
    bucket: ((s3-stemcell-bucket))
    region_name: ((s3-stemcell-region-name))
    # customization is required to remove bosh prefix in stemcell name
-    regexp: ((stemcell-name-prefix))((stemcell-main-name))/bosh-stemcell-(.*)-((stemcell-main-name)).tgz


We may want to remove this.

o-orand

Explanations in the Readme are fine.
We may add openstack samples

o-orand · 2018-07-12T15:40:30Z

Dockerfile

@@ -24,6 +24,17 @@ RUN curl -sfL "https://codeclimate.com/downloads/test-reporter/test-reporter-lat
 RUN curl -sfL "https://raw.githubusercontent.com/ekalinin/github-markdown-toc/master/gh-md-toc" > /usr/local/bin/gh-md-toc \
  && chmod a+x /usr/local/bin/gh-md-toc

+RUN curl -sfL "https://github.com/starkandwayne/bucc/archive/v0.5.0.tar.gz" > bucc.tar.gz \


We should see if we can use concourse to download bucc from github instead of a manual download

o-orand · 2018-07-12T15:42:42Z

Readme.md

+    - deploy_transiant_infra: you can deactivate this step if you already have an infrastructure with BOSH and Concourse
+    - upload_stemcell: you can deactivate this step if you don't want a new stemcell to be uploaded to the BOSH Director
+    - upload_cloud_config: you can deactivate this step if you don't want to overwrite the cloud config of the BOSH Director
+    - install_git_server: you can deactivate this step if you have the git-server deployment already deployed on the BOSH Director


or a private git repo

o-orand · 2018-07-12T15:47:39Z

ci/bootstrap_coa_env/prereqs.yml

+  secrets-branch: master
+  paas-templates-branch: master
+  cf-ops-automation-uri: http://github.com/orange-cloudfoundry/cf-ops-automation/
+  cf-ops-automation-branch: 113_coa_env_bootstrap


we need to set it to master before merging this PR

o-orand · 2018-07-12T15:48:56Z

concourse/pipelines/template/depls-pipeline.yml.erb

@@ -112,7 +112,7 @@ resources:
    bucket: ((s3-stemcell-bucket))
    region_name: ((s3-stemcell-region-name))
    # customization is required to remove bosh prefix in stemcell name
-    regexp: ((stemcell-name-prefix))((stemcell-main-name))/bosh-stemcell-(.*)-((stemcell-main-name)).tgz
+    regexp: ((stemcell-name-prefix))/bosh-stemcell-(.*)-((stemcell-main-name)).tgz


Requires #128 or skip this change

o-orand · 2018-07-12T15:49:04Z

concourse/pipelines/template/depls-pipeline.yml.erb

@@ -452,7 +452,7 @@ jobs:
    - get: secrets-full-writer
      params: { submodules: none}
    - get: bosh-stemcell
-      version: { path: ((stemcell-name-prefix))((stemcell-main-name))/bosh-stemcell-((stemcell-version))-((stemcell-main-name)).tgz }
+      version: { path: ((stemcell-name-prefix))/bosh-stemcell-((stemcell-version))-((stemcell-main-name)).tgz }


Requires #128 or skip this change

o-orand · 2018-07-12T15:49:12Z

concourse/pipelines/template/depls-pipeline.yml.erb

@@ -831,7 +831,7 @@ jobs:
          echo "check-resource -r $BUILD_PIPELINE_NAME/<%= name %> --from version:((<%= name %>-version))" >> result-dir/flight-plan
    <% end %>
  <% end %>
-          echo "check-resource -r $BUILD_PIPELINE_NAME/bosh-stemcell --from path:((stemcell-name-prefix))((stemcell-main-name))/bosh-stemcell-((stemcell-version))-((stemcell-main-name)).tgz" >> result-dir/flight-plan
+          echo "check-resource -r $BUILD_PIPELINE_NAME/bosh-stemcell --from path:((stemcell-name-prefix))/bosh-stemcell-((stemcell-version))-((stemcell-main-name)).tgz" >> result-dir/flight-plan


Requires #128 or skip this change

o-orand · 2018-07-12T15:57:14Z

lib/coa_env_bootstrapper/prereqs.example.yml

+  stemcell-main-name: warden-boshlite-ubuntu-trusty-go_agent
+  stemcell-version: "3586.25"
+  s3-stemcell-endpoint: https://s3.amazonaws.com
+  s3-stemcell-skip-ssl-verification: false


this is a large configuration file, but I'm not sure it is possible to have a smaller one :-(

o-orand · 2018-07-12T15:59:28Z

scripts/extract-credentials-list.rb

@@ -0,0 +1,20 @@
+#!/usr/bin/env ruby -w
+


please add a usage, and we may rename it to be more explicit (like extract-pipeline-credentials-list.rb)

o-orand · 2018-07-12T16:09:03Z

spec/helpers/utils.rb

+  File.join(File.join(File.dirname(__FILE__), '..', path, 'fixtures'))
+end
+
+def new_tmpdir_path


Why not using mktmpdir ?, so we won't need tmp/.gitkeep

spec/spec_helper.rb

@@ -133,5 +135,4 @@ def fly(arg, env = {})
  def execute(cmd, env = {})
    fly("execute #{cmd}", env)
  end
-
 end


o-orand · 2018-07-12T16:16:26Z

to fix the stemcells issue, we need the online stemcell support (#128)

o-orand

Do NOT merge due to change into depls-pipeline abour the stemcell

lucaspinto · 2018-07-19T10:46:11Z

I updated the branch.

o-orand · 2018-07-19T12:33:46Z

Could you please fix the following codeclimate issue:

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition. - Found in scripts/extract_pipeline_credentials_list.rb by rubocop
- if path = ARGV[0]
Align the parameters of a method call if they span more than one line. - Found in lib/coa_env_bootstrapper/base.rb by rubocop
- :prereqs
Lists should be surrounded by blank lines New - Found in Readme.md by markdownlint
- inactive_steps (optional): pass a list of steps that will be deactivated in case you wouldn't need them to run, for instance in case you have some resources already installed. You can deactivate:
Bare URL used New - Found in Readme.md by markdownlint
- bin_path: the path to your installation of the bucc project. The project can be found at https://github.com/starkandwayne/bucc

o-orand · 2018-07-19T12:44:28Z

Could you rebase and squash both commits into one.

o-orand · 2018-07-25T15:19:37Z

scripts/extract_pipeline_credentials_list.rb

+  files.each do |path|
+    next if File.directory?(path)
+    pipeline_content = File.read(path)
+    creds_list << pipeline_content.scan(/\(\(([\w|-]*)\)\)/).flatten.uniq


please use %r{ } syntax

lucaspinto · 2018-07-25T16:18:24Z

I still need to fix the docs.

lucaspinto · 2018-07-26T11:52:09Z

Docs fixed

o-orand · 2018-07-27T09:43:18Z

We still need to work on running bootstrap on openstack

lucaspinto requested a review from o-orand July 11, 2018 09:34

lucaspinto commented Jul 11, 2018

View reviewed changes

lucaspinto force-pushed the 113_coa_env_bootstrap branch 8 times, most recently from c93923f to 64a0209 Compare July 12, 2018 08:16

o-orand reviewed Jul 12, 2018

View reviewed changes

o-orand requested changes Jul 12, 2018

View reviewed changes

lucaspinto force-pushed the 113_coa_env_bootstrap branch 5 times, most recently from 4fe5f23 to f6756bd Compare July 19, 2018 10:09

lucaspinto force-pushed the 113_coa_env_bootstrap branch 3 times, most recently from cb3627e to eabb3d9 Compare July 19, 2018 15:55

o-orand reviewed Jul 25, 2018

View reviewed changes

lucaspinto force-pushed the 113_coa_env_bootstrap branch from eabb3d9 to b1d7304 Compare July 25, 2018 16:17

lucaspinto force-pushed the 113_coa_env_bootstrap branch 2 times, most recently from db083ae to 3a3aee0 Compare July 26, 2018 07:26

o-orand approved these changes Jul 26, 2018

View reviewed changes

lucaspinto force-pushed the 113_coa_env_bootstrap branch from 3a3aee0 to a7c0fba Compare July 26, 2018 11:51

lucaspinto force-pushed the 113_coa_env_bootstrap branch from a7c0fba to afdfd01 Compare July 26, 2018 11:53

o-orand force-pushed the 113_coa_env_bootstrap branch 2 times, most recently from b835458 to 5eeae60 Compare July 27, 2018 09:16

bootstrap-coa-env(*)

5eeae60

o-orand merged commit c233387 into develop Jul 27, 2018

o-orand deleted the 113_coa_env_bootstrap branch July 27, 2018 09:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bootstrap-coa-env(*) #164

bootstrap-coa-env(*) #164

lucaspinto commented Jul 11, 2018

lucaspinto Jul 11, 2018

o-orand left a comment

o-orand Jul 12, 2018

o-orand Jul 12, 2018

o-orand Jul 12, 2018

o-orand Jul 12, 2018

o-orand Jul 12, 2018

o-orand Jul 12, 2018

o-orand Jul 12, 2018

o-orand Jul 12, 2018

o-orand Jul 12, 2018

This comment was marked as resolved.

o-orand commented Jul 12, 2018

o-orand left a comment

lucaspinto commented Jul 19, 2018

o-orand commented Jul 19, 2018

o-orand commented Jul 19, 2018

o-orand Jul 25, 2018

lucaspinto commented Jul 25, 2018

lucaspinto commented Jul 26, 2018

o-orand commented Jul 27, 2018

bootstrap-coa-env(*) #164

bootstrap-coa-env(*) #164

Conversation

lucaspinto commented Jul 11, 2018

Choose a reason for hiding this comment

o-orand left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as resolved.

o-orand commented Jul 12, 2018

o-orand left a comment

Choose a reason for hiding this comment

lucaspinto commented Jul 19, 2018

o-orand commented Jul 19, 2018

o-orand commented Jul 19, 2018

Choose a reason for hiding this comment

lucaspinto commented Jul 25, 2018

lucaspinto commented Jul 26, 2018

o-orand commented Jul 27, 2018