reply with status unauthorized when serving login page

orange-cloudfoundry · Mar 13, 2021 · 4e1c06a · 4e1c06a
1 parent fec61b2
commit 4e1c06a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/auth_handler.go b/auth_handler.go
@@ -134,6 +134,7 @@ func (a AuthHandler) loginPage(w http.ResponseWriter, req *http.Request) {
 		return
 	}
 	if req.Method == http.MethodGet {
+		w.WriteHeader(http.StatusUnauthorized)
 		w.Write([]byte(makeLoginPageHtml(
 			loginPageTemplate,
 			strings.Title(a.aggrRoute.Name),

diff --git a/auth_handler_test.go b/auth_handler_test.go
@@ -118,7 +118,7 @@ var _ = Describe("AuthHandler", func() {
 
 				authHandler.ServeHTTP(respRecorder, req)
 
-				Expect(respRecorder.Code).To(Equal(http.StatusOK))
+				Expect(respRecorder.Code).To(Equal(http.StatusUnauthorized))
 				Expect(respRecorder.Body.String()).To(Equal("Test: /"))
 			})
 			When("Post username and password from login page", func() {