Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New resource/datasource cloudavenue_backup #558

Merged
merged 6 commits into from
Oct 11, 2023
Merged

feat: New resource/datasource cloudavenue_backup #558

merged 6 commits into from
Oct 11, 2023

Conversation

dmicheneau
Copy link
Member

@dmicheneau dmicheneau commented Oct 6, 2023 •
edited
Loading

Add new resource cloudavenue_backup

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

source ~/.cloud_avenue.source && TF_ACC=1 go test  -v ./internal/testsacc/ -count=1 -timeout 30m -run TestAccBackupResource
=== RUN   TestAccBackupResource
--- PASS: TestAccBackupResource (238.81s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  239.111s

source ~/.cloud_avenue.source && TF_ACC=1 go test -v ./internal/testsacc/ -count=1 -timeout 30m -run TestAccBackupDataSource
=== RUN   TestAccBackupDataSource
--- PASS: TestAccBackupDataSource (176.99s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  177.284s

@dmicheneau dmicheneau linked an issue Oct 6, 2023 that may be closed by this pull request
[New Resource]: cloudavenue_backup - Set policies applied to the VDC, VApp or VM scope #544
Closed
@crown-app
Copy link

crown-app bot commented Oct 6, 2023

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@crown-app crown-app bot added Feature size/XL Extra large PR labels Oct 6, 2023
@dmicheneau dmicheneau changed the title [feature]: Add new resource cloudavenue_backup feature: New resource cloudavenue_backup Oct 6, 2023
@crown-app
Copy link

crown-app bot commented Oct 6, 2023

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@dmicheneau dmicheneau changed the title feature: New resource cloudavenue_backup feat: New resource cloudavenue_backup Oct 6, 2023
@dmicheneau dmicheneau self-assigned this Oct 6, 2023
@dmicheneau
Copy link
Member Author

Waiting to solve WAF issue in order to implement refresh sync between NetBackup and VCD.
And also will permit to Implement TestACC

@dmicheneau dmicheneau added this to the v0.13.0 milestone Oct 6, 2023
@dmicheneau dmicheneau force-pushed the 544-new-resource-cloudavenue_backup-set-policies-applied-to-the-vdc-vapp-or-vm-scope branch from 4c8bdf1 to 163db6e Compare October 6, 2023 21:12
azrod
azrod requested changes Oct 8, 2023
View reviewed changes
Copy link
Member

@azrod azrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Datasource

go.mod Outdated Show resolved Hide resolved
internal/provider/backup/backup_resource.go Outdated Show resolved Hide resolved
internal/provider/backup/backup_schema.go Outdated Show resolved Hide resolved
internal/provider/backup/backup_schema.go Outdated Show resolved Hide resolved
internal/provider/backup/backup_types.go Outdated Show resolved Hide resolved
docs/resources/backup.md Outdated Show resolved Hide resolved
@dmicheneau dmicheneau force-pushed the 544-new-resource-cloudavenue_backup-set-policies-applied-to-the-vdc-vapp-or-vm-scope branch from 163db6e to c58d894 Compare October 9, 2023 09:51
@dmicheneau dmicheneau linked an issue Oct 9, 2023 that may be closed by this pull request
[New Data Source]: cloudavenue_backup- Retrieve details of policies #545
Closed
@dmicheneau dmicheneau force-pushed the 544-new-resource-cloudavenue_backup-set-policies-applied-to-the-vdc-vapp-or-vm-scope branch from fceb23d to 7b2807d Compare October 10, 2023 07:35
@dmicheneau dmicheneau force-pushed the 544-new-resource-cloudavenue_backup-set-policies-applied-to-the-vdc-vapp-or-vm-scope branch from 7b2807d to 1797421 Compare October 10, 2023 07:58
@dmicheneau dmicheneau marked this pull request as ready for review October 10, 2023 07:59
@dmicheneau dmicheneau requested a review from a team as a code owner October 10, 2023 07:59
azrod
azrod requested changes Oct 10, 2023
View reviewed changes
docs/resources/backup.md Outdated Show resolved Hide resolved
internal/provider/backup/backup_resource.go Outdated Show resolved Hide resolved
internal/provider/backup/backup_resource.go Outdated Show resolved Hide resolved
internal/provider/backup/backup_resource.go Outdated Show resolved Hide resolved
internal/provider/backup/backup_resource.go Outdated Show resolved Hide resolved
internal/provider/backup/backup_schema.go Outdated Show resolved Hide resolved
internal/provider/backup/backup_schema_test.go Outdated Show resolved Hide resolved
internal/provider/provider_datasources.go Outdated Show resolved Hide resolved
internal/testsacc/backup_datasource_test.go Show resolved Hide resolved
internal/testsacc/backup_resource_test.go Outdated Show resolved Hide resolved
@dmicheneau dmicheneau force-pushed the 544-new-resource-cloudavenue_backup-set-policies-applied-to-the-vdc-vapp-or-vm-scope branch from 1797421 to 94861fb Compare October 10, 2023 15:15
@crown-app crown-app bot added the Fix label Oct 10, 2023
azrod
azrod reviewed Oct 11, 2023
View reviewed changes
internal/client/client.go Outdated Show resolved Hide resolved
internal/provider/provider.go Outdated Show resolved Hide resolved
@dmicheneau dmicheneau force-pushed the 544-new-resource-cloudavenue_backup-set-policies-applied-to-the-vdc-vapp-or-vm-scope branch from 0741632 to d4eb29f Compare October 11, 2023 12:34
@dmicheneau dmicheneau force-pushed the 544-new-resource-cloudavenue_backup-set-policies-applied-to-the-vdc-vapp-or-vm-scope branch from d4eb29f to 99b21df Compare October 11, 2023 13:19
azrod
azrod approved these changes Oct 11, 2023
View reviewed changes
internal/client/client.go Outdated Show resolved Hide resolved
internal/testsacc/backup_datasource_test.go Outdated Show resolved Hide resolved
@azrod azrod changed the title feat: New resource cloudavenue_backup feat: New resource/datasource cloudavenue_backup Oct 11, 2023
@dmicheneau dmicheneau merged commit 8d5a9c6 into main Oct 11, 2023
4 checks passed
@dmicheneau dmicheneau deleted the 544-new-resource-cloudavenue_backup-set-policies-applied-to-the-vdc-vapp-or-vm-scope branch October 11, 2023 13:22
azrod pushed a commit that referenced this pull request Oct 11, 2023
chore: update CHANGELOG.md for #558
2dc53ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azrod azrod azrod approved these changes

Assignees

@dmicheneau dmicheneau

Labels
size/XL Extra large PR
Projects
None yet
Milestone
v0.13.0
2 participants
@dmicheneau @azrod