Changes from review comments in 8036 PR #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
sid-srini
previously approved these changes
Dec 27, 2024
|
@subhash-arabhi test is failing due to patch not applying cleanly, can you please have a look at that part and fix that if possible Test Link: https://github.com/oracle/javavscode/actions/runs/12513291686/job/34908392017?pr=356 |
sid-srini
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Thanks @subhash-arabhi. LGTM 👍
Please squash the commits before we merge. Thanks.
Updated patch
subhash-arabhi
force-pushed
the
new-updates-8036-patch
branch
from
67b8d83 to
5b24214
Compare
sid-srini
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates based on PR comments - #8036