Change to use declarative types with @graphql-tools/schema #362
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
There was a problem hiding this comment.
Hey @salma-bek,
Please solve the merge conflicts so that we can merge this change.
| const getBooks = async (SEARCH_URL) => { | ||
| import { makeExecutableSchema } from 'graphql-tools-schema'; | ||
| import 'mle-js-fetch'; | ||
| import oracledb from 'mle-js-oracledb'; |
There was a problem hiding this comment.
It might no longer be necessary to import oracledb. Instead of
const connection = oracledb.defaultConnection();
const result = connection.execute()
you can simply reference the session object in the global scope. This will make it easier later on to bundle the code. Unless of course something else in the oracledb namespace is needed that MLE doesn't provide in the global scope.
| }, | ||
| Book: { | ||
| stock: async (book) => { | ||
| const conn = oracledb.defaultConnection(); |
There was a problem hiding this comment.
please consider using session.execute() here.
| }, | ||
| }; | ||
|
|
||
| const getBooks = async (SEARCH_URL) => { | ||
| const conn = oracledb.defaultConnection(); |
There was a problem hiding this comment.
please consider using session.execute() instead
| `); | ||
|
|
||
| const response = await fetch(`${BASE_URL}${SEARCH_URL}`, { credentials: "include" }); |
There was a problem hiding this comment.
beginning with Oracle Database 23.3 it should no longer be necessary to use createntials: include
|
In addition to the comments in the code, please add instructions how to use rollup to generate a bundle of |
The purpose of this PR is to use declarative types with @graphql-tools/schema instead of GraphQL’s reference implementation