Fix IDE warnings

.github/workflows/maven.yml

@@ -1,7 +1,7 @@
 # This workflow will build a Java project with Maven
 # For more information see: https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven
 
-name: Java CI with Maven
+name: Maven Build
 
 on:
   push:

README.md

@@ -1,6 +1,6 @@
 ![Build Status](https://github.com/opwvhk/avro-conversions/workflows/Java%20CI%20with%20Maven/badge.svg)
-[![license](doc/license-APACHE-2.0-brightgreen.svg)](https://www.apache.org/licenses/LICENSE-2.0.html)
-[![Maven Central](https://maven-badges.herokuapp.com/maven-central/net.sf.opk/avro-conversions/badge.svg)](https://maven-badges.herokuapp.com/maven-central/net.sf.opk/avro-conversions)
+[![License](https://img.shields.io/github/license/opwvhk/avro-conversions?color=brightgreen)](https://www.apache.org/licenses/LICENSE-2.0.html)
+[![Maven Central Version](https://img.shields.io/maven-central/v/net.sf.opk/avro-conversions?color=brightgreen)](https://maven-badges.herokuapp.com/maven-central/net.sf.opk/avro-conversions)
 
 Avro Conversions
 ================

pom.xml

@@ -53,12 +53,6 @@
 	</properties>
 	<dependencies>
 		<!-- Basics -->
-		<dependency>
-			<groupId>org.projectlombok</groupId>
-			<artifactId>lombok</artifactId>
-			<version>1.18.30</version>
-			<scope>provided</scope>
-		</dependency>
 		<dependency>
 			<groupId>org.slf4j</groupId>
 			<artifactId>slf4j-api</artifactId>
@@ -94,16 +88,6 @@
 			<artifactId>avro-compiler</artifactId>
 			<version>${avro.version}</version>
 		</dependency>
-		<dependency>
-			<groupId>com.fasterxml.jackson.core</groupId>
-			<artifactId>jackson-core</artifactId>
-			<version>${jackson.version}</version>
-		</dependency>
-		<dependency>
-			<groupId>com.fasterxml.jackson.core</groupId>
-			<artifactId>jackson-databind</artifactId>
-			<version>${jackson.version}</version>
-		</dependency>
 		<dependency>
 			<groupId>org.apache.commons</groupId>
 			<artifactId>commons-text</artifactId>
@@ -129,7 +113,17 @@
 			<version>2.3.1</version>
 		</dependency>
 
-		<!-- JSON Schema related -->
+		<!-- JSON & JSON Schema related -->
+		<dependency>
+			<groupId>com.fasterxml.jackson.core</groupId>
+			<artifactId>jackson-core</artifactId>
+			<version>${jackson.version}</version>
+		</dependency>
+		<dependency>
+			<groupId>com.fasterxml.jackson.core</groupId>
+			<artifactId>jackson-databind</artifactId>
+			<version>${jackson.version}</version>
+		</dependency>
 		<dependency>
 			<!-- From JITPack https://jitpack.io/ -->
 			<groupId>net.jimblackler.jsonschemafriend</groupId>

src/main/java/opwvhk/avro/io/AsAvroParserBase.java

@@ -209,7 +209,7 @@ protected AsAvroParserBase(GenericData model, ZoneId defaultTimezone) {
     }
 
     /**
-     * Collect all fields in a record schema, mapped by their names (i.e. name and aliases).
+     * Collect all fields in a record schema, mapped by their names (i.e., name and aliases).
      *
      * @param recordSchema a record schema
      * @return all fields, mapped by all their names
@@ -445,7 +445,7 @@ public ValueResolver createResolver(WriteSchema writeSchema, Schema readSchema)
     /**
      * Factory interface to create resolvers based on a read and write schema.
      */
-    protected interface ResolverFactory<WriteSchema> {
+    public interface ResolverFactory<WriteSchema> {
         /**
          * Create a resolver.
          *

src/main/java/opwvhk/avro/io/RecordResolver.java

@@ -17,7 +17,7 @@ public class RecordResolver
         extends ValueResolver {
     private static final Object NOT_SET = new Object();
 
-    private final GenericData model;
+	private final GenericData model;
     private final Schema recordSchema;
     private final Map<String, ValueResolver> resolversByName;
     private final Map<String, Schema.Field> fieldsByName;

src/main/java/opwvhk/avro/io/ScalarValueResolver.java

@@ -2,8 +2,6 @@
 
 import java.util.function.Function;
 
-import static java.util.Objects.requireNonNull;
-
 /**
  * A resolver for scalar values. Supports content, but ignores any properties.
  */

src/main/java/opwvhk/avro/json/SchemaAnalyzer.java

@@ -125,7 +125,7 @@ private Schema asAvroSchema(SchemaProperties schemaProperties, IdentityHashMap<S
                         // Assume a scalar value
                         ValueResolver resolver = new AsAvroParserBase<>(GenericData.get()) {
                             @Override
-                            public ValueResolver createResolver(Schema readSchema) {
+                            protected ValueResolver createResolver(Schema readSchema) {
                                 return super.createResolver(readSchema);
                             }
                         }.createResolver(fieldSchema);

src/main/java/opwvhk/avro/util/Utils.java

@@ -2,8 +2,6 @@
 
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
-import java.util.Collection;
-import java.util.EnumSet;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Locale;
@@ -234,20 +232,20 @@ public static <T> T nonRecursive(String algorithm, Object caller, Object differe
 	/**
 	 * Check if a map is not empty. Throws otherwise.
 	 *
-	 * @param map the map to check
+	 * @param map     the map to check
 	 * @param message the exception message to use when the map is null or empty
 	 * @return the map
 	 */
-	public static <T extends Map<?,?>> T requireNonEmpty(T map, String message) {
+	public static <T extends Map<?, ?>> T requireNonEmpty(T map, String message) {
 		return require(map, m -> m != null && !m.isEmpty(), message);
 	}
 
 	/**
 	 * Check if a requirement holds. Throws otherwise.
 	 *
-	 * @param object the object to check
+	 * @param object    the object to check
 	 * @param assertion the assertion on the object that must hold
-	 * @param message the exception message to use when the assertion fails
+	 * @param message   the exception message to use when the assertion fails
 	 * @return the object
 	 */
 	public static <T> T require(T object, Predicate<T> assertion, String message) {
@@ -261,23 +259,23 @@ private Utils() {
 		// Utility class: no need to instantiate.
 	}
 
-    /**
+	/**
 	 * <p>Simple pair class with equality check (!) on its contents, useful to prevent infinite recursion.</p>
-     *
-     * <p>Suggested use is as keys of a {@link Map} or {@link Set}, where one would use an {@link java.util.IdentityHashMap IdentityHashMap} if there were
-     * only one value. One such usage is in the method {@link #nonRecursive(String, Object, Object, Object, Supplier)}, where the pairs of {@code caller} and
-     * {@code differentiator} are used to check if the method should allow recursion, or return a default value instead.</p>
+	 *
+	 * <p>Suggested use is as keys of a {@link Map} or {@link Set}, where one would use an {@link java.util.IdentityHashMap IdentityHashMap} if there were
+	 * only one value. One such usage is in the method {@link #nonRecursive(String, Object, Object, Object, Supplier)}, where the pairs of {@code caller} and
+	 * {@code differentiator} are used to check if the method should allow recursion, or return a default value instead.</p>
 	 */
 	public static class Seen {
 		private final Object left;
 		private final Object right;
 
-	    /**
-	     * Create a 'seen' pair.
-	     *
-	     * @param left one of the values to check against
-	     * @param right the other value to check against
-	     */
+		/**
+		 * Create a 'seen' pair.
+		 *
+		 * @param left  one of the values to check against
+		 * @param right the other value to check against
+		 */
 		public Seen(Object left, Object right) {
 			this.left = left;
 			this.right = right;

src/main/java/opwvhk/avro/xml/SimpleContentAdapter.java

@@ -1,7 +1,5 @@
 package opwvhk.avro.xml;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 import org.xml.sax.Attributes;
 import org.xml.sax.SAXException;
 import org.xml.sax.SAXParseException;
@@ -17,10 +15,6 @@
  * <p>Requires the parser to support namespaces (and return namespace attributes).</p>
  */
 class SimpleContentAdapter extends DefaultHandler {
-	/**
-	 * Logger for this class.
-	 */
-	private static final Logger LOGGER = LoggerFactory.getLogger(SimpleContentAdapter.class);
 	private static final int DEFAULT_BUFFER_CAPACITY = 1024;
 	private final SimpleContentHandler simpleContentHandler;
 	private final boolean enforceXsd;

src/main/java/opwvhk/avro/xml/XsdAnalyzer.java

@@ -19,7 +19,6 @@
 import org.apache.ws.commons.schema.utils.NamespacePrefixList;
 import org.apache.ws.commons.schema.walker.FixedXmlSchemaWalker;
 import org.apache.ws.commons.schema.walker.XmlSchemaVisitor;
-import org.apache.ws.commons.schema.walker.XmlSchemaWalker;
 import org.xml.sax.helpers.DefaultHandler;
 
 import static java.nio.charset.StandardCharsets.UTF_8;

src/main/java/opwvhk/avro/xml/datamodel/TypeWithUnparsedContent.java

@@ -3,7 +3,7 @@
 import org.apache.avro.Schema;
 
 /**
- * A type with unparsed content. This means the type has a text field named "value", where the XML  parser can place the content of an XML element.
+ * A type with unparsed content. This means the type has a text field named "value", where the XML parser can place the content of an XML element.
  *
  * @param actualType the actual type (with a text field named "value")
  */