Refactor resolver to base class

README.md

@@ -73,6 +73,13 @@ Upgrade notes
 2. Constructing a JSON parser can no longer throw a (library specific) `GenerationException`; this
    has become a runtime exception instead.
 
+
+Logging
+-------
+
+This library uses SLF4J, redirects Commons-Logging over SLF4J, and includes a dependency to direct the JDK 1.4 logging framework to SLF4J as well (one of the dependencies uses it). To correctly log via SLF4J, use the provided file `logging.properties` to configure java.util.logging.
+
+
 Contributing ✨
 ---------------
 

logging.properties

@@ -0,0 +1,18 @@
+#
+# Copyright © Oscar Westra van Holthe - Kind
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+#
+# register SLF4JBridgeHandler as handler for the j.u.l. root logger
+handlers = org.slf4j.bridge.SLF4JBridgeHandler

pom.xml

@@ -58,15 +58,19 @@
 		</dependency>
 		<dependency>
 			<groupId>org.slf4j</groupId>
-			<artifactId>slf4j-simple</artifactId>
+			<artifactId>jul-to-slf4j</artifactId>
 			<version>${org.slf4j.version}</version>
-			<scope>runtime</scope>
 		</dependency>
 		<dependency>
 			<groupId>org.slf4j</groupId>
 			<artifactId>jcl-over-slf4j</artifactId>
 			<version>${org.slf4j.version}</version>
-			<scope>runtime</scope>
+		</dependency>
+		<dependency>
+			<groupId>org.slf4j</groupId>
+			<artifactId>slf4j-simple</artifactId>
+			<version>${org.slf4j.version}</version>
+			<scope>test</scope>
 		</dependency>
 
 		<!-- Avro & Parquet related -->
@@ -133,6 +137,10 @@
 					<groupId>commons-collections</groupId>
 					<artifactId>commons-collections</artifactId>
 				</exclusion>
+				<exclusion>
+					<groupId>commons-logging</groupId>
+					<artifactId>commons-logging</artifactId>
+				</exclusion>
 			</exclusions>
 		</dependency>
 		<dependency>
@@ -167,6 +175,7 @@
 		</dependency>
 	</dependencies>
 	<build>
+		<defaultGoal>clean verify</defaultGoal>
 		<pluginManagement>
 			<plugins>
 				<plugin>
@@ -204,6 +213,44 @@
 					</excludes>
 				</configuration>
 			</plugin>
+			<plugin>
+				<groupId>com.github.siom79.japicmp</groupId>
+				<artifactId>japicmp-maven-plugin</artifactId>
+				<version>0.20.0</version>
+				<configuration>
+					<skip>true</skip>
+					<parameter>
+						<!--
+							The plugin finds all versions (in order) in the repository up to the current project version. It excludes
+							snapshots and all versions that do not match this pattern (if given). Then it takes the last version and
+							compares the current API against that.
+						-->
+						<!--<oldVersionPattern>${previous.version}</oldVersionPattern>-->
+						<ignoreMissingOldVersion>true</ignoreMissingOldVersion>
+						<onlyModified>true</onlyModified>
+						<breakBuildBasedOnSemanticVersioning>true</breakBuildBasedOnSemanticVersioning>
+						<breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
+						<ignoreNonResolvableArtifacts>true</ignoreNonResolvableArtifacts>
+						<ignoreMissingOptionalDependency>true</ignoreMissingOptionalDependency>
+						<excludeModules>
+							<!-- Exclude modules that are not part of the public API, don't have classes but have missing dependencies, etc. -->
+							<!--<excludeModule>parquet-benchmarks</excludeModule>-->
+						</excludeModules>
+						<excludes>
+							<!-- Due to the removal of deprecated methods -->
+							<!--<exclude>org.apache.parquet.arrow.schema.SchemaMapping</exclude>-->
+						</excludes>
+					</parameter>
+				</configuration>
+				<executions>
+					<execution>
+						<phase>verify</phase>
+						<goals>
+							<goal>cmp</goal>
+						</goals>
+					</execution>
+				</executions>
+			</plugin>
 		</plugins>
 	</build>
 	<repositories>